Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for nested CSS #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onmax
Copy link

@onmax onmax commented Nov 13, 2024

πŸ”— Linked issue

#371

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds support for nested CSS when the module parses CSS.

I don't want to create a lot of tests, so the test I have added is minimal but covers different nested CSS situations

@onmax onmax force-pushed the onmax/support-nested-css branch 2 times, most recently from 2b5506a to 4f4c8f6 Compare November 14, 2024 10:50
@onmax onmax marked this pull request as ready for review November 14, 2024 10:51
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (b726fa2) to head (4f4c8f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/transform.ts 87.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   83.85%   84.54%   +0.68%     
==========================================
  Files          13       13              
  Lines        1016     1029      +13     
  Branches      266      270       +4     
==========================================
+ Hits          852      870      +18     
+ Misses        158      153       -5     
  Partials        6        6              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants