Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input/Textarea): nullify model modifier #2309

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

Gerbuuun
Copy link
Contributor

@Gerbuuun Gerbuuun commented Oct 5, 2024

πŸ”— Linked issue

resolves #2281

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds model modifier which makes the input return null instead of a falsy value (most importantly undefined and "")
See linked issue for explanation.
This is a follow-up of the #2275 PR

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
    Modifiers are not documented right now, should I add something about them?

@Gerbuuun Gerbuuun changed the title feat(Input/Textarea): add nullify model modifier feat(Input/Textarea): nullify model modifier Oct 5, 2024
Copy link
Collaborator

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wrapped my mind around it, and I think the implementation is simple enough to integrate. Thanks!

@benjamincanac
Copy link
Member

@romhml Shouldn't this be done on all form components for consistency? πŸ€”

@benjamincanac benjamincanac merged commit 9dd7e61 into nuxt:dev Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input/Textarea nullify modifier
3 participants