fix: formatting YAML properties and exporting a cjs build #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
added a commit
to adamdehaven/vscode-mdc
that referenced
this pull request
Jan 14, 2025
This PR depends on nuxtlabs/monarch-mdc#12 to export a cjs build in order to consume the formatter from a single source of truth.
Fix formatting YAML props in nested block components. Output a CommonJS module in addition to ESM, primarily for utilizing the formatter function in @nuxtlabs/vscode-mdc.
adamdehaven
force-pushed
the
fix/build-commonjs
branch
from
b0e4c0b to
4e2b080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Refactor
getDocumentFoldingRangesfunctionChore
unbuildconfig to a file (for readability).I'm utilizing the exported
formatterandgetDocumentFoldingRangesfunctions in nuxtlabs/vscode-mdc#41 in order to source the MDC formatting and folding logic from a single source of truth rather than replicating the code there.The
formatterfunction should remain "unbound" to the monarch (or textmate) language, as it can be used standalone as a utility for properly formatting MDC strings in any downstream project.