Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if value is an object to properly simple quote value #81

Merged
merged 1 commit into from
May 27, 2024

Conversation

ManUtopiK
Copy link
Contributor

Hi!

I fixed a bug that occur only on transformation from AST to markdown when a component has an array attribute.

Input :

::container-component{:items='["Nuxt", "Vue"]'}
::

Before :

::container-component{:items="["Nuxt", "Vue"]"}
::

After this fix :

::container-component{:items='["Nuxt", "Vue"]'}
::

I followed the spec of the JSON string.

I added a bunch of tests around component's attributes...

Copy link

codesandbox bot commented May 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@atinux atinux requested a review from farnabaz May 22, 2024 13:16
@farnabaz farnabaz merged commit c61760c into nuxtlabs:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants