Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sascha Cowley <[email protected]>
  • Loading branch information
LeonarddeR and SaschaCowley authored Feb 4, 2025
1 parent cd69c95 commit 64592bb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion projectDocs/dev/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __getattr__(attrName: str) -> Any:

## Deprecating extension points

Support for deprecations is included in the several extensionPoint classes.
Support for deprecations is included in the various extensionPoint classes.

For example:

Expand Down
1 change: 1 addition & 0 deletions source/extensionPoints/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ class HandlerRegistrar(Generic[HandlerT]):

def __init__(self, *, _deprecationMessage: str | None = None):
"""Initialise the handler registrar.
:param _deprecationMessage: Optional deprecation message to be logged when :method:`register` is called on the handler.
"""
self._deprecationMessage = _deprecationMessage
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

# For braille unit tests, we need to enable the braille handler by providing it display dimensions
# Give the display one row with 40 cells
def getFakeDisplayDimensions(dimensions: braille.DisplayDimensions) -> int:
def getFakeDisplayDimensions(dimensions: braille.DisplayDimensions) -> braille.DisplayDimensions:
return braille.DisplayDimensions(numRows=1, numCols=40)


Expand Down

0 comments on commit 64592bb

Please sign in to comment.