Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Introducing table sayall commands (#13670)" #13954

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jul 27, 2022

Link to issue number:

Reverts: #13670, #13901
Fixes #13927
Re-introduces: #13469

Summary of the issue:

The fix for #13927 is complex, and will need weeks of testing on alpha.
This means that #13469 is blocked until #13670 can be implemented with #13927 fixed.

Description of user facing changes

Removes table say all commands from 2022.3

Description of development approach

Revert PRs in the right order, fix up the release blurb

Testing strategy:

#13670 has been confirmed as the commit which broke #13927 using a git bisect.
The build from this code has been tested with bookworm.

Known issues with pull request:

None

Change log entries:

See PR diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested review from a team as code owners July 27, 2022 03:46
@seanbudd seanbudd requested review from Qchristensen and feerrenrut and removed request for a team July 27, 2022 03:46
@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Jul 27, 2022
@seanbudd seanbudd added this to the 2022.3 milestone Jul 27, 2022
@AppVeyorBot
Copy link

See test results for failed build of commit fd18032e21

@seanbudd seanbudd merged commit 9d25bac into beta Jul 27, 2022
@seanbudd seanbudd deleted the revert-table-sayall branch July 27, 2022 05:37
seanbudd added a commit that referenced this pull request Jul 27, 2022
@seanbudd seanbudd mentioned this pull request Jul 27, 2022
5 tasks
mltony added a commit to mltony/nvda that referenced this pull request Aug 25, 2022
mltony added a commit to mltony/nvda that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/blocking this issue blocks the milestone release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants