-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Add-ons section of Quick start guide #16618
Conversation
@seanbudd or @gerald-hartig, please note that in the future, it would be nice to avoid merging an important part of the User Guide just before the translation freeze as done with #16553. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some specific comments below:
@Qchristensen, sorry, I have not been able to take the time to review in detail #16553 before it was merged. Here ar my suggestion. |
Co-authored-by: Sean Budd <[email protected]>
Thanks @CyrilleB79 - all good pickups, and yes, apologies for merging #16553 so late - the idea was something encouraged by feedback given, so we wanted to try to include it for 2024.2, but yes, it was a later inclusion than would have been desirable. Thanks for your understanding! |
Co-authored-by: Quentin Christensen <[email protected]>
Various rewording found while translating.
Link to issue number:
None
Summary of the issue:
Various re-wordings
needed in the Add-on Store section of the Quick start Guide in the User Guide. Some of them less important than others.
Description of user facing changes
User Guide modified.
Description of development approach
N/A
Testing strategy:
Check the generated file.
Known issues with pull request:
None
Code Review Checklist:
Note
NVDA 2024.2 translation freeze has just begun. I have opened this PR against beta branch, but feel free to decline and I will rebase to master; I may also push only some of the change in beta if you wish.
The idea by targeting beta was to update the text before some translators translate it.