Say all, move caret per word instead of per line/sentence #9937

LeonarddeR · 2019-07-16T17:38:02Z

Link to issue number:

Summary of the issue:

When using say all, the caret moves per sentence or per line, not per word. This is not very helpful when using magnification or braille to track the current position of say all. More importantly though, when reviewing text with say all, exiting say all makes you end up at the start of the line or sentence, not at the current word's position.

Say all also doesn't follow in browse mode.

Description of how this pull request fixes the issue:

Find white space using regex, and bring the caret to it accordingly. This avoids fetching text info per word, which can be pretty expensive.

This option can be found in the speech settings: "Increase caret updates during say all"

Testing performed:

Tested in Word, Notepad and browse mode that the caret follows read words. Note that there is a minimal 0.5 seconds interval between every caret update to avoid the caret going mad on higher speechrates.

Known issues with pull request:

With espeak, I've heard speech stuttering on higher rates with rate boost on. There may also be performance implications in browse mode. That's why this option is off by default.
No changes to the documentation yet. I want to be sure about the option wording and its default state first.

Change log entry:

Changes
- During say all, the caret position can now be updated more frequently to better resemble the current reading position. For this, enable the new "Increase caret updates during say all" option in NVDA's speech settings. #(9937)

DrSooom · 2019-07-17T13:16:37Z

Wrong branche?

LeonarddeR · 2019-07-17T13:23:26Z

@DrSooom: Could you elaborate?

DrSooom · 2019-07-17T14:11:28Z

"nvaccess:master" instead of "nvaccess:threshold". Compare with PR #9946.

LeonarddeR · 2019-07-17T15:01:06Z

that's intentional. This won't go into master before threshold is merged.

DrSooom · 2019-07-26T16:39:12Z

GitHub still shows 145 commits for this PR after Threshold was merged into Master. Keep an eye on it. (I thought that GitHub respectively git would be more intelligent.)

LeonarddeR · 2019-07-26T16:41:55Z

Interesting. I intended to rebase it. May be I did something wrong. thanks for pointing uit.

…ultiple sentences

LeonarddeR · 2019-07-27T10:51:30Z

Issue should now be fixed.

derekriemer

Increase caret updates during say all sounds wordy to me. How about "Move cursor by word during say all"

derekriemer · 2019-08-04T21:02:17Z

source/config/configSpec.py

@@ -37,6 +37,7 @@
 	outputDevice = string(default=default)
 	autoLanguageSwitching = boolean(default=true)
 	autoDialectSwitching = boolean(default=false)
+	increaseSayAllCaretUpdates = boolean(default=false)


Should this be a speech synth dependent setting? For example, users may have many synths, and some might work better with this feature than others.

@derekriemer wrote:

Increase caret updates during say all sounds wordy to me. How about "Move cursor by word during say all"

Because while the caret is intended to move per word, the movement is also limited to once per half a second.

Ugh, sorry for the comment above, it ended up at the wrong place.

Anyway, making this a per synth setting makes sense to me. I will do that.

source/speech/__init__.py

source/speech/commands.py

derekriemer · 2019-08-04T21:24:28Z

source/speech/commands.py

@@ -253,12 +260,27 @@ class CallbackCommand(BaseCallbackCommand):
 		otherwise it will block production of further speech and or other functionality in NVDA.
 	"""

-	def __init__(self, callback):
+	def __init__(self, callback: Union[SUPPORTED_CALLBACK_TYPES]):


Is a class with a call supported by this union?

No. The only way to acoomplish this seems to be the use of collections.abc.Callable, but that also applies to classes itself. I'm reluctant to do this.

Fixed typo Co-Authored-By: Derek Riemer <[email protected]>

Co-Authored-By: Derek Riemer <[email protected]>

AppVeyorBot · 2019-08-05T11:41:17Z

PR introduces Flake8 errors 😲

See test results for Failed build of commit 23b707621c

…speech

…is code from 2017 and later

derekriemer · 2019-08-10T09:19:51Z

No.

…

On Mon, Aug 5, 2019 at 5:20 AM Leonard de Ruijter ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In source/config/configSpec.py <#9937 (comment)>: > @@ -37,6 +37,7 @@ outputDevice = string(default=default) autoLanguageSwitching = boolean(default=true) autoDialectSwitching = boolean(default=false) + increaseSayAllCaretUpdates = boolean(default=false) @derekriemer <https://github.com/derekriemer> wrote: Increase caret updates during say all sounds wordy to me. How about "Move cursor by word during say all" Because while the caret is intended to move per word, the movement is also limited to once per half a second. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9937?email_source=notifications&email_token=ABI2FPP2C5AH6ZWBVU5GN6TQDAEIPA5CNFSM4IEDJ4KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCARKAEI#discussion_r310556034>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABI2FPLVUTNWTSXDPSL6HYDQDAEIPANCNFSM4IEDJ4KA> .

-- Derek Riemer: Improving the world one byte at a time! - University of Colorado Boulder Department of computer science, 4th year undergraduate student. - Accessibility enthusiast. - Proud user of the NVDA screen reader. - Open source enthusiast. - Skier. Personal website <http://derekriemer.com>

derekriemer · 2019-08-10T09:20:04Z

It starts with _, so it's probably fine. On Sat, Aug 10, 2019 at 3:19 AM Derek Scott Riemer < [email protected]> wrote:

…

No. On Mon, Aug 5, 2019 at 5:20 AM Leonard de Ruijter < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In source/config/configSpec.py > <#9937 (comment)>: > > > @@ -37,6 +37,7 @@ > outputDevice = string(default=default) > autoLanguageSwitching = boolean(default=true) > autoDialectSwitching = boolean(default=false) > + increaseSayAllCaretUpdates = boolean(default=false) > > @derekriemer <https://github.com/derekriemer> wrote: > > Increase caret updates during say all sounds wordy to me. How about "Move > cursor by word during say all" > > Because while the caret is intended to move per word, the movement is > also limited to once per half a second. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#9937?email_source=notifications&email_token=ABI2FPP2C5AH6ZWBVU5GN6TQDAEIPA5CNFSM4IEDJ4KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCARKAEI#discussion_r310556034>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABI2FPLVUTNWTSXDPSL6HYDQDAEIPANCNFSM4IEDJ4KA> > . > -- Derek Riemer: Improving the world one byte at a time! - University of Colorado Boulder Department of computer science, 4th year undergraduate student. - Accessibility enthusiast. - Proud user of the NVDA screen reader. - Open source enthusiast. - Skier. Personal website <http://derekriemer.com>

-- Derek Riemer: Improving the world one byte at a time! - University of Colorado Boulder Department of computer science, 4th year undergraduate student. - Accessibility enthusiast. - Proud user of the NVDA screen reader. - Open source enthusiast. - Skier. Personal website <http://derekriemer.com>

AppVeyorBot · 2019-11-21T09:42:00Z

PR introduces Flake8 errors 😲

See test results for Failed build of commit ada9083620

LeonarddeR · 2019-11-26T14:04:04Z

I wrote this pull request on behalf of @BabbageCom. As I'm leaving @BabbageCom after the 29th of November, I can no longer afford maintaining this pr other than applying very basic review actions. If this pull request requires major changes, they will have to be applied by someone else, e.g. @sjfbol or whoever else is willing to take it.

AppVeyorBot · 2020-02-17T11:20:13Z

Unit test failure
Build (for testing PR)

See test results for failed build of commit 20cf56ec97

AppVeyorBot · 2020-02-18T08:01:41Z

Unit test failure
Build (for testing PR)

See test results for failed build of commit 4092c7d318

feerrenrut · 2020-04-08T11:56:50Z

It would be worth considering how "vision enhancement providers" fit into this. It would be good if focus highlight followed the current word being spoken.

LeonarddeR · 2020-04-08T12:01:37Z

I agree, though that might be something more suitable for a follow up pr.

LeonarddeR · 2020-07-16T17:22:17Z

This has merge conflicts. I'm currently in a situation where I neither have the time nor interest to fix them, it just requires too much attention and thorough testing. Apart from @BabbageCom, is there anyone who think this change would be a huge benefit and can take this over?

Adriani90 · 2020-07-16T20:52:15Z

cc: @Andre9642, @CyrilleB79, @JulienCochuyt Imo this would bring some benefits for braille users but also for people using focus highlighting.

feerrenrut · 2020-07-22T12:48:50Z

This is certainly something I would be interested in working on. I have a vague plan to use a mechanism like this to improve the speech viewer. I don't think I can prioritize this immediately, so if anyone else has capacity and interest, feel free to take it on. But if not, we will get to this eventually. 😄

dawidpieper · 2020-09-13T21:07:08Z

I can take it. What is the procedure? Should I create yet another PR?

feerrenrut · 2020-09-14T08:31:41Z

I can take it. What is the procedure? Should I create yet another PR?

Yes, thanks @dawidpieper. Make a copy of this branch, and create a new PR from that branch, comment on this PR with the new PR number and I'll close this one. That will make it clear to everyone that you intend to take over the development.

LeonarddeR · 2020-09-30T17:29:18Z

Closing as superseded by #11658

LeonarddeR changed the title ~~Say all, move caret per word instead per line/sentence~~ Say all, move caret per word instead of per line/sentence Jul 16, 2019

LeonarddeR mentioned this pull request Jul 17, 2019

Log never handled speech indexes, and don't make the speech queue lag behind #9946

Merged

Leonard de Ruijter added 5 commits July 27, 2019 12:51

Split lineReached into a separate _bookmarkReached function

8f0921c

Change the re_last_pause regex to consume less of a line containing m…

ce53201

…ultiple sentences

Add a nice repr to callback commands for easier debugging

ff1872c

Make the caret follow say all more closely

07b90c8

Say all, use obj.selection = updater instead of updater.updateCaret()

3225897

derekriemer suggested changes Aug 4, 2019

View reviewed changes

LeonarddeR and others added 2 commits August 5, 2019 13:24

Update source/speech/__init__.py

3341210

Fixed typo Co-Authored-By: Derek Riemer <[email protected]>

Apply suggestions from code review

db74dc6

Co-Authored-By: Derek Riemer <[email protected]>

Leonard de Ruijter added 8 commits August 9, 2019 16:08

Merge remote-tracking branch 'origin/master' into sayAll

7bf925c

Make the caret per word setting a synth setting instead of global to …

795b6ca

…speech

Rename of private _TextCommand class to _TextChunk

c1d0fb2

Rename cb to callback

f67bbd3

Add type info to speech.speakTextInfo

4947f97

re.UNICODE is now obsolete, no longer use it

28abd3c

Fix copyright of speech/commands. This is part of speech refactor so …

c832f7e

…is code from 2017 and later

linter satisfaction

7af96e2

LeonarddeR mentioned this pull request Aug 22, 2019

Improve scrolling experience in browse mode #9919

Closed

LeonarddeR marked this pull request as ready for review August 22, 2019 07:25

LeonarddeR mentioned this pull request Nov 7, 2019

While reading text, play a sound for spelling errors instead of saying "spelling error". #10474

Closed

Merge remote-tracking branch 'origin/master' into sayAll

9e9918b

Linting fix

21c310d

Merge remote-tracking branch 'origin/master' into sayAll

1dc834d

Fix more merge conflicts

60f53b5

Support test_SpeechWithoutPauses

5f2154c

DrSooom mentioned this pull request Feb 26, 2020

Feature Request: move caret to current word being read #10819

Closed

feerrenrut added component/speech-synth-drivers component/speech component/vision Framework for assisting users with low vision feature/say-all feature labels Apr 8, 2020

Merge remote-tracking branch 'origin/master' into sayAll

aad4c99

CyrilleB79 mentioned this pull request May 5, 2020

Stopping speech at a precise point #8955

Open

LeonarddeR added the Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. label Jul 16, 2020

dawidpieper mentioned this pull request Sep 22, 2020

Say all, move caret per word instead of per line/sentence, taken over after abandoned 9937 #11658

Closed

LeonarddeR closed this Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Say all, move caret per word instead of per line/sentence #9937

Say all, move caret per word instead of per line/sentence #9937

LeonarddeR commented Jul 16, 2019 •

edited

Loading

DrSooom commented Jul 17, 2019

LeonarddeR commented Jul 17, 2019

DrSooom commented Jul 17, 2019

LeonarddeR commented Jul 17, 2019 via email

DrSooom commented Jul 26, 2019

LeonarddeR commented Jul 26, 2019 via email

LeonarddeR commented Jul 27, 2019

derekriemer left a comment

derekriemer Aug 4, 2019

LeonarddeR Aug 5, 2019

LeonarddeR Aug 5, 2019

derekriemer Aug 4, 2019

LeonarddeR Aug 9, 2019

AppVeyorBot commented Aug 5, 2019

derekriemer commented Aug 10, 2019 via email

derekriemer commented Aug 10, 2019 via email

AppVeyorBot commented Nov 21, 2019

LeonarddeR commented Nov 26, 2019

AppVeyorBot commented Feb 17, 2020

AppVeyorBot commented Feb 18, 2020

feerrenrut commented Apr 8, 2020

LeonarddeR commented Apr 8, 2020 via email

LeonarddeR commented Jul 16, 2020

Adriani90 commented Jul 16, 2020

feerrenrut commented Jul 22, 2020

dawidpieper commented Sep 13, 2020

feerrenrut commented Sep 14, 2020

LeonarddeR commented Sep 30, 2020

Say all, move caret per word instead of per line/sentence #9937

Say all, move caret per word instead of per line/sentence #9937

Conversation

LeonarddeR commented Jul 16, 2019 • edited Loading

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

DrSooom commented Jul 17, 2019

LeonarddeR commented Jul 17, 2019

DrSooom commented Jul 17, 2019

LeonarddeR commented Jul 17, 2019 via email

DrSooom commented Jul 26, 2019

LeonarddeR commented Jul 26, 2019 via email

LeonarddeR commented Jul 27, 2019

derekriemer left a comment

Choose a reason for hiding this comment

derekriemer Aug 4, 2019

Choose a reason for hiding this comment

LeonarddeR Aug 5, 2019

Choose a reason for hiding this comment

LeonarddeR Aug 5, 2019

Choose a reason for hiding this comment

derekriemer Aug 4, 2019

Choose a reason for hiding this comment

LeonarddeR Aug 9, 2019

Choose a reason for hiding this comment

AppVeyorBot commented Aug 5, 2019

derekriemer commented Aug 10, 2019 via email

derekriemer commented Aug 10, 2019 via email

AppVeyorBot commented Nov 21, 2019

LeonarddeR commented Nov 26, 2019

AppVeyorBot commented Feb 17, 2020

AppVeyorBot commented Feb 18, 2020

feerrenrut commented Apr 8, 2020

LeonarddeR commented Apr 8, 2020 via email

LeonarddeR commented Jul 16, 2020

Adriani90 commented Jul 16, 2020

feerrenrut commented Jul 22, 2020

dawidpieper commented Sep 13, 2020

feerrenrut commented Sep 14, 2020

LeonarddeR commented Sep 30, 2020

LeonarddeR commented Jul 16, 2019 •

edited

Loading