-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vpi_stereo #681
Open
ctracey-nv
wants to merge
17
commits into
nvidia-holoscan:main
Choose a base branch
from
ctracey-nv:dev/vpi-stereo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add vpi_stereo #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new application that shows how to integrate VPI in Holohub and run stereo disparity estimation. Signed-off-by: Colin Tracey <[email protected]>
Rather than repeatedly creating and destroying heavy-wieght VPI objects, initialize them in start, reuse in compute, then teardown in stop. Signed-off-by: Colin Tracey <[email protected]>
Parse the VPI stereo parameters from yaml config file rather than hard-coding them. Signed-off-by: Colin Tracey <[email protected]>
0 indicates invalid disparity, so should be visually distinct. Signed-off-by: Colin Tracey <[email protected]>
The INFERENCE confidence type has better results overall, so use it when possible. Signed-off-by: Colin Tracey <[email protected]>
Decouple the desired resolution for disparity estimation from the input resolution of the video frames. Rescale as necessary Signed-off-by: Colin Tracey <[email protected]>
Verified on an IGX 1.1 system using Holoscan 2.6 base image Signed-off-by: Colin Tracey <[email protected]>
Fix up the README and adjust application IO to reuse the stereo_vision sample data and reduce the number of files in this sample app. Signed-off-by: Colin Tracey <[email protected]>
Multiple headers and libraries were not actually required. Trim the excess. Signed-off-by: Colin Tracey <[email protected]>
Add a colorful gif to make the readme more fun. Signed-off-by: Colin Tracey <[email protected]>
Since Dockerfile will be picked up by default, no need to be explicit in adding it. Also move required envar into dockerfile itself, and add a little more context to the application description. Signed-off-by: Colin Tracey <[email protected]>
It's 2025 now. Signed-off-by: Colin Tracey <[email protected]>
Add replayer source option like stereo_vision has Signed-off-by: Colin Tracey <[email protected]>
Some extra packages which shouldn't be required. Signed-off-by: Colin Tracey <[email protected]>
Signed-off-by: Colin Tracey <[email protected]>
1e6e9e2
to
0023c84
Compare
add a short (10 frame) test suitible for automated sanity testing using ctest. Signed-off-by: Colin Tracey <[email protected]>
Minor cosmetic issues identified by lint scripts. Some seem questionable, like 'multi-line string' when just a string literal with R is being used. Signed-off-by: Colin Tracey <[email protected]>
f8264f7
to
93264fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the vpi_stereo sample app to demonstrate the following: