Fix file navigation delay in Ruby caused by ts indent #1164
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7892c0c.
|
Do we need to set additional_vim_regex_highlighting to false? (Edit: nvm I checked the default value is false) |
|
Does this cause a regression of #747? |
|
@ChillerDragon I was not aware of this - it does indeed. I pushed a change to disable ts indenting for Ruby again to fix this regression. Thanks! Removal of |
|
nice thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to / Fixes issue #1141.
Caused by
additional_vim_regex_highlighting = { 'ruby' }line for Ruby in kickstart ts config that was introduced in this commit .The problem this solved at the time seems redundant now (most likely fixed upstream in
treesitter), and now introduces a small delay when navigating in files instead.I reverted the commit - restoring default ts indenting for it, in turn making config simpler.Edit: Only ts regex highlighting was removed to avoid regressions - thanks @ChillerDragon.