Set breakpoint icons and their highlight colors #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be a overall comment that users can uncomment if they want this change. |
iton0
reviewed
Oct 18, 2024
lua/kickstart/plugins/debug.lua
Outdated
| vim.api.nvim_set_hl(0, 'Break', { fg = '#e51400' }) | ||
| vim.api.nvim_set_hl(0, 'Stop', { fg = '#ffcc00' }) | ||
| local breakpoint_icons = vim.g.have_nerd_font | ||
| and { Breakpoint = '', BreakpointCondition = '', BreakpointRejected = '', LogPoint = '', Stopped = '' } |
There was a problem hiding this comment.
I think it be better to just have one table of icons
There was a problem hiding this comment.
Thank you for reviewing the code. With all due respect, that might not be possible.
If vim.g.have_nerd_font is false, the local variable breakpoint_icons would no longer exist.
Error that occurs when deleting the line:
Cannot assign `boolean|table` to parameter `<T:table>`.
- `boolean` cannot match `table`
- Type `boolean` cannot match `table` [param-type-mismatch]
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so
|
Hi guys I have no feelings on this. @iton0 Can you help me understand why you think this should just be optional? Do you use/do other people use different conditional break symbols? |
|
I appreciate the overall addition, but I wanted to make it optional for caution's sake. This way, users can experience the default debugging setup first and choose to add features if they wish, rather than having to remove anything. |
|
Ah I failed to notice it's already commented out. merging! |
codemedic
added a commit
to codemedic/kickstart.nvim
that referenced
this pull request
Oct 30, 2024
* master: Remove two because there are more than two. (nvim-lua#1213) Set breakpoint icons and their highlight colors (nvim-lua#1194) Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) Disable linting autocmd for readonly buffers (nvim-lua#1202) fix: update lazy uninstall information link (nvim-lua#1148)
feoh
pushed a commit
to feoh/kickstart.nvim
that referenced
this pull request
Oct 30, 2024
* feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email>
whalderman
pushed a commit
to whalderman/kickstart.nvim
that referenced
this pull request
Nov 3, 2024
* feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email>
ginjiruu
pushed a commit
to ginjiruu/kickstart.nvim
that referenced
this pull request
Nov 4, 2024
* feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email>
Livingpool
pushed a commit
to Livingpool/kickstart.nvim
that referenced
this pull request
Nov 5, 2024
* feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set breakpoint icons and their highlight colors in
lua/kickstart/plugins/debug.lua; see Here for details