Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c_sharp) add @assignment support for all possible assignable statements #720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(c_sharp) add @assignment support for all possible assignable statements #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions queries/c_sharp/textobjects.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,64 @@

; comments
(comment) @comment.outer

; assignments
(field_declaration
(_)
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs
(_) @assignment.rhs) @assignment.inner)) @assignment.outer

(field_declaration
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs
(_) @assignment.rhs) @assignment.inner)) @assignment.outer

(field_declaration
(_)
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs @assignment.inner))) @assignment.outer

(local_declaration_statement
(_)
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs
(_) @assignment.rhs) @assignment.inner)) @assignment.outer

(local_declaration_statement
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs
(_) @assignment.rhs) @assignment.inner)) @assignment.outer

(local_declaration_statement
(_)
(variable_declaration
type: (_)
(variable_declarator
name: (_) @assignment.lhs @assignment.inner))) @assignment.outer

(expression_statement
(assignment_expression
left: (_) @assignment.lhs
right: (_) @assignment.rhs)) @assignment.inner @assignment.outer
Copy link
Collaborator

@kiyoon kiyoon Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inner and outer should not mean the same thing. Inner refers to "either" LHS or RHS, outer means select both. Sorry, this isn't documented very clearly as of now. (although I wrote a comment on this query, all queries seem to be wrong and need to be fixed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will fix these queries and add test cases.


(method_declaration
name: (_) @assignment.lhs
body: (arrow_expression_clause
(_) @assignment.rhs) @assignment.inner) @assignment.outer

(local_function_statement
type: (_)
name: (_) @assignment.lhs
body: (arrow_expression_clause
(_) @assignment.rhs)) @assignment.inner @assignment.outer
Loading