Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: fine tune user interface #158

Merged
merged 48 commits into from
Oct 3, 2024
Merged

Conversation

xiaoshihou514
Copy link
Collaborator

@xiaoshihou514 xiaoshihou514 commented Aug 9, 2024

This pr fine tunes the user interface according to nvim-best-practices

  • use Guard + subcommands instead of multiple individual commands
  • remove / deprecate the setup function, ft(...):fmt should work immediately
  • finer typing for ft(...):fmt, ft(...):lint, etc. HARD, maybe later
  • versioning with luarocks-tag-release
  • remove some of the vim.validate calls for perf
  • issue templates from haskell-tools.nvim
  • allow formatter to be a function that returns the table
  • print stderr on fail (reason?)

@xiaoshihou514
Copy link
Collaborator Author

@glepnir I think you would have to add some repo secrets as instructed here

@xiaoshihou514 xiaoshihou514 marked this pull request as ready for review August 18, 2024 13:47
@xiaoshihou514 xiaoshihou514 requested a review from glepnir August 18, 2024 13:48
@xiaoshihou514 xiaoshihou514 changed the title feat: fine tune user interface feat!: fine tune user interface Aug 18, 2024
@xiaoshihou514
Copy link
Collaborator Author

It seems like vim.fn.executable may return 1 for tools that are installed by mason but not in PATH, I added a check for this in lua/guard/health.lua.

spec/autocmd_spec.lua Outdated Show resolved Hide resolved
@nvimdev nvimdev deleted a comment from xiaoshihou514 Aug 22, 2024
@glepnir
Copy link
Member

glepnir commented Aug 25, 2024

also create a .luarc.json file for luals config.

@glepnir
Copy link
Member

glepnir commented Aug 31, 2024

thinking about create a floating window to show the all config of user defined and config for current buffer. like lspinfo we can call guard info or something else.

@xiaoshihou514
Copy link
Collaborator Author

thinking about create a floating window to show the all config of user defined and config for current buffer. like lspinfo we can call guard info or something else.

I went for just printing, though that would be nice.

@glepnir
Copy link
Member

glepnir commented Aug 31, 2024

yup. but no rush. can in the subsequent PR

@xiaoshihou514
Copy link
Collaborator Author

Added info in floating markdown window :)

plugin/guard.lua Outdated Show resolved Hide resolved
plugin/guard.lua Outdated Show resolved Hide resolved
plugin/guard.lua Show resolved Hide resolved
@xiaoshihou514 xiaoshihou514 merged commit f99cbcf into nvimdev:main Oct 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants