-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[New]
nvm use/nvm install: add --save option
Fixes #2849. Co-authored-by: Martin <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
- Loading branch information
3 people
committed
Mar 17, 2024
1 parent
811c039
commit 28ebb07
Showing
8 changed files
with
312 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ test/bak | |
| .urchin.log | ||
| .urchin_stdout | ||
| test/**/test_output | ||
| test/**/.nvmrc | ||
|
|
||
| node_modules/ | ||
| npm-debug.log | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ test/bak | |
| .urchin.log | ||
| .urchin_stdout | ||
| test/**/test_output | ||
| test/**/.nvmrc | ||
|
|
||
| node_modules/ | ||
| npm-debug.log | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
test/fast/Unit tests/Running 'nvm install --save' works as expected'
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #!/bin/sh | ||
| \. ../../../nvm.sh | ||
| \. ../../common.sh | ||
|
|
||
| set -e | ||
|
|
||
| TEST_VERSION="v0.2.4" | ||
|
|
||
| if [ -f .nvmrc ]; then mv .nvmrc .nvmrc.orig; fi | ||
|
|
||
| cleanup () { | ||
| rm -rf .nvmrc "$(nvm_version_path "$(nvm_format_version "$TEST_VERSION")")" | ||
| if [ -f .nvmrc.orig ]; then mv .nvmrc.orig .nvmrc; fi | ||
| unset -f nvm_ls_remote nvm_ls_remote_iojs | ||
| } | ||
|
|
||
| die () { | ||
| echo "$@" | ||
| cleanup | ||
| exit 1 | ||
| } | ||
|
|
||
| REMOTE="$PWD/mocks/nvm_ls_remote.txt" | ||
| nvm_ls_remote() { | ||
| cat "$REMOTE" | ||
| } | ||
| REMOTE_IOJS="$PWD/mocks/nvm_ls_remote_iojs.txt" | ||
| nvm_ls_remote_iojs() { | ||
| cat "$REMOTE_IOJS" | ||
| } | ||
|
|
||
| make_fake_node "$TEST_VERSION" | ||
|
|
||
| nvm install --save "$TEST_VERSION" || die "\`nvm install --save $TEST_VERSION\` failed" | ||
| OUTPUT="$(cat .nvmrc)" | ||
|
|
||
| nvm_is_valid_version "$(cat .nvmrc)" \ | ||
| || die "\`nvm install --save $TEST_VERSION\`+ \`cat .nvmrc\` outputted invalid version: got '${OUTPUT}'" | ||
|
|
||
| cleanup |
54 changes: 54 additions & 0 deletions
54
test/fast/Unit tests/Running 'nvm use --save' works with a .nvmrc in the parent dir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #!/bin/sh | ||
| \. ../../../nvm.sh | ||
| \. ../../common.sh | ||
|
|
||
| set -e | ||
|
|
||
| TEST_VERSION="v0.2.4" | ||
|
|
||
| if [ -f .nvmrc ]; then mv .nvmrc .nvmrc.orig; fi | ||
| if [ -f ../.nvmrc ]; then mv ../.nvmrc ../.nvmrc.orig; fi | ||
|
|
||
| del_nvmrc () { | ||
| rm -f .nvmrc ../.nvmrc | ||
| } | ||
|
|
||
| cleanup () { | ||
| del_nvmrc | ||
| rm -rf "$(nvm_version_path "$(nvm_format_version "$TEST_VERSION")")" | ||
| if [ -f .nvmrc.orig ]; then mv .nvmrc.orig .nvmrc; fi | ||
| if [ -f ../.nvmrc.orig ]; then mv ../.nvmrc.orig ../.nvmrc; fi | ||
| unset -f nvm_ls_remote nvm_ls_remote_iojs | ||
| } | ||
|
|
||
| die () { | ||
| echo "$@" | ||
| cleanup | ||
| exit 1 | ||
| } | ||
|
|
||
| REMOTE="$PWD/mocks/nvm_ls_remote.txt" | ||
| nvm_ls_remote() { | ||
| cat "$REMOTE" | ||
| } | ||
| REMOTE_IOJS="$PWD/mocks/nvm_ls_remote_iojs.txt" | ||
| nvm_ls_remote_iojs() { | ||
| cat "$REMOTE_IOJS" | ||
| } | ||
|
|
||
| del_nvmrc | ||
| make_fake_node "$TEST_VERSION" | ||
|
|
||
| (cd .. | ||
| nvm use --save "$TEST_VERSION" || die "\`nvm use --save $TEST_VERSION\` failed in the parent dir") | ||
| nvm use --save || die "\`nvm use --save\` failed" | ||
|
|
||
| [ -f ../.nvmrc ] && [ -f .nvmrc ] || die "expected two .nvmrc files to be generated" | ||
|
|
||
| OUTPUT=$(cat .nvmrc) | ||
| EXPECTED_OUTPUT="$(cat ../.nvmrc)" | ||
|
|
||
| [ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] \ | ||
| || die "invalid \`nvm use --save \` output: expected '$EXPECTED_OUTPUT'; got '$OUTPUT'" | ||
|
|
||
| cleanup |
40 changes: 40 additions & 0 deletions
40
test/fast/Unit tests/Running 'nvm use --silent --save' doesn't output anything
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #!/bin/sh | ||
| \. ../../../nvm.sh | ||
| \. ../../common.sh | ||
|
|
||
| set -e | ||
|
|
||
| TEST_VERSION="v0.2.4" | ||
|
|
||
| if [ -f .nvmrc ]; then mv .nvmrc .nvmrc.orig; fi | ||
|
|
||
| cleanup () { | ||
| rm -rf .nvmrc "$(nvm_version_path "$(nvm_format_version "$TEST_VERSION")")" | ||
| if [ -f .nvmrc.orig ]; then mv .nvmrc.orig .nvmrc; fi | ||
| unset -f nvm_ls_remote nvm_ls_remote_iojs | ||
| } | ||
|
|
||
| die () { | ||
| echo "$@" | ||
| cleanup | ||
| exit 1 | ||
| } | ||
|
|
||
| REMOTE="$PWD/mocks/nvm_ls_remote.txt" | ||
| nvm_ls_remote() { | ||
| cat "$REMOTE" | ||
| } | ||
| REMOTE_IOJS="$PWD/mocks/nvm_ls_remote_iojs.txt" | ||
| nvm_ls_remote_iojs() { | ||
| cat "$REMOTE_IOJS" | ||
| } | ||
|
|
||
| make_fake_node "$TEST_VERSION" | ||
|
|
||
| OUTPUT=$(nvm use --save --silent "$TEST_VERSION" || die "\`nvm use --save --silent $TEST_VERSION\` failed") | ||
| EXPECTED_OUTPUT="" | ||
|
|
||
| [ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] \ | ||
| || die "\`nvm use --save --silent $TEST_VERSION\` output was not silenced to '$EXPECTED_OUTPUT'; got '$OUTPUT'" | ||
|
|
||
| cleanup |
59 changes: 59 additions & 0 deletions
59
test/fast/Unit tests/Running 'nvm use -w' works as expected'
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| #!/bin/sh | ||
| \. ../../../nvm.sh | ||
|
|
||
| set -e | ||
|
|
||
| if [ -f .nvmrc ]; then mv .nvmrc .nvmrc.orig; fi | ||
|
|
||
| TEST_VERSION="v0.2.4" | ||
|
|
||
| cleanup () { | ||
| rm -rf .nvmrc "$(nvm_version_path "$(nvm_format_version "$TEST_VERSION")")" | ||
| if [ -f .nvmrc.orig ]; then mv .nvmrc.orig .nvmrc; fi | ||
| unset -f nvm_ls_remote nvm_ls_remote_iojs | ||
| } | ||
|
|
||
| die () { | ||
| echo "$@" | ||
| cleanup | ||
| exit 1 | ||
| } | ||
|
|
||
| nvm deactivate 2>/dev/null || die 'unable to deactivate' | ||
|
|
||
| \. ../../common.sh | ||
|
|
||
| # REMOTE="$PWD/mocks/nvm_ls_remote.txt" | ||
| # nvm_ls_remote() { | ||
| # cat "$REMOTE" | ||
| # } | ||
| # REMOTE_IOJS="$PWD/mocks/nvm_ls_remote_iojs.txt" | ||
| # nvm_ls_remote_iojs() { | ||
| # cat "$REMOTE_IOJS" | ||
| # } | ||
|
|
||
| make_fake_node "$TEST_VERSION" | ||
|
|
||
| # 1. install | ||
|
|
||
| nvm install -w "$TEST_VERSION" || die "\`nvm install -w $TEST_VERSION\` failed" | ||
| OUTPUT="$(cat .nvmrc)" | ||
|
|
||
| nvm_is_valid_version "$(cat .nvmrc)" \ | ||
| || die "\`nvm install -w $TEST_VERSION\`+ \`cat .nvmrc\` outputted invalid version: got '${OUTPUT}'" | ||
|
|
||
| # | ||
|
|
||
| unset OUTPUT | ||
|
|
||
| # 2. use | ||
|
|
||
| nvm use -w "$TEST_VERSION" || die "\`nvm use -w $TEST_VERSION\` failed" | ||
| OUTPUT="$(cat .nvmrc)" | ||
|
|
||
| nvm_is_valid_version "$(cat .nvmrc)" \ | ||
| || die "\`nvm use -w $TEST_VERSION\`+ \`cat .nvmrc\` outputted invalid version: got '${OUTPUT}'" | ||
|
|
||
| # | ||
|
|
||
| cleanup |
Oops, something went wrong.