Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The following sequence of events can cause a segfault: 1. ThrottlingURLLoader::Start is called to kick off a request 2. A throttle's WillStartRequest method redirects the request by changing ResourceRequest::url 3. ThrottlingURLLoader::StartNow is called, possibly after deferral 4. StartNow calls ThrottlingURLLoader::OnReceivedRedirect because the request URL was changed in step 2 5. A throttle's WillRedirectRequest method defers the redirect 6. When handling the defer, OnReceivedRedirect calls client_binding_.PauseIncomingMethodCallProcessing, which segaults because client_binding_ is unbound because the request never actually started Bug: 933538 Change-Id: I0f7033d159d34601421da781f7902b6ae207c58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511620 Reviewed-by: John Abd-El-Malek <[email protected]> Commit-Queue: Robbie McElrath <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#639178}(cherry picked from commit a86e86d90b35de30ed66b5f0337a082474a01913) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519287 Reviewed-by: Robbie McElrath <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#72} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
- Loading branch information