[mac] fix for component build on osx

.eslintignore

@@ -1,9 +1,8 @@
 lib/internal/v8_prof_polyfill.js
-lib/internal/v8_prof_processor.js
 lib/punycode.js
 test/addons/??_*/
 test/fixtures
-test/**/node_modules
 test/disabled
 test/tmp*/
-tools/doc/node_modules
+tools/eslint
+node_modules

.eslintrc

@@ -5,76 +5,83 @@ env:
 rules:
   # Possible Errors
   # http://eslint.org/docs/rules/#possible-errors
-  comma-dangle: [2, "only-multiline"]
+  comma-dangle: [2, only-multiline]
   no-control-regex: 2
   no-debugger: 2
   no-dupe-args: 2
   no-dupe-keys: 2
   no-duplicate-case: 2
   no-empty-character-class: 2
   no-ex-assign: 2
-  no-extra-boolean-cast : 2
-  no-extra-parens: [2, "functions"]
+  no-extra-boolean-cast: 2
+  no-extra-parens: [2, functions]
   no-extra-semi: 2
   no-func-assign: 2
   no-invalid-regexp: 2
   no-irregular-whitespace: 2
-  no-negated-in-lhs: 2
   no-obj-calls: 2
   no-proto: 2
+  no-template-curly-in-string: 2
   no-unexpected-multiline: 2
   no-unreachable: 2
+  no-unsafe-negation: 2
   use-isnan: 2
   valid-typeof: 2
 
   # Best Practices
   # http://eslint.org/docs/rules/#best-practices
   no-fallthrough: 2
+  no-global-assign: 2
+  no-multi-spaces: 2
   no-octal: 2
   no-redeclare: 2
   no-self-assign: 2
   no-unused-labels: 2
 
   # Strict Mode
   # http://eslint.org/docs/rules/#strict-mode
-  strict: [2, "global"]
+  strict: [2, global]
 
   # Variables
   # http://eslint.org/docs/rules/#variables
   no-delete-var: 2
   no-undef: 2
-  no-unused-vars: [2, {"args": "none"}]
+  no-unused-vars: [2, {args: none}]
 
   # Node.js and CommonJS
   # http://eslint.org/docs/rules/#nodejs-and-commonjs
   no-mixed-requires: 2
   no-new-require: 2
   no-path-concat: 2
-  no-restricted-modules: [2, "sys", "_linklist"]
+  no-restricted-modules: [2, sys, _linklist]
 
   # Stylistic Issues
   # http://eslint.org/docs/rules/#stylistic-issues
+  brace-style: [2, 1tbs, {allowSingleLine: true}]
   comma-spacing: 2
   eol-last: 2
-  indent: [2, 2, {SwitchCase: 1}]
+  func-call-spacing: 2
+  indent: [2, 2, {SwitchCase: 1, MemberExpression: 1}]
+  key-spacing: [2, {mode: minimum}]
   keyword-spacing: 2
+  linebreak-style: [2, unix]
   max-len: [2, 80, 2]
   new-parens: 2
   no-mixed-spaces-and-tabs: 2
   no-multiple-empty-lines: [2, {max: 2}]
   no-trailing-spaces: 2
-  quotes: [2, "single", "avoid-escape"]
+  quotes: [2, single, avoid-escape]
   semi: 2
-  space-before-blocks: [2, "always"]
-  space-before-function-paren: [2, "never"]
-  space-in-parens: [2, "never"]
+  space-before-blocks: [2, always]
+  space-before-function-paren: [2, never]
+  space-in-parens: [2, never]
   space-infix-ops: 2
   space-unary-ops: 2
 
   # ECMAScript 6
   # http://eslint.org/docs/rules/#ecmascript-6
-  arrow-parens: [2, "always"]
-  arrow-spacing: [2, {"before": true, "after": true}]
+  arrow-parens: [2, always]
+  arrow-spacing: [2, {before: true, after: true}]
   constructor-super: 2
   no-class-assign: 2
   no-confusing-arrow: 2
@@ -83,28 +90,34 @@ rules:
   no-new-symbol: 2
   no-this-before-super: 2
   prefer-const: 2
+  rest-spread-spacing: 2
+  template-curly-spacing: 2
 
   # Custom rules in tools/eslint-rules
-  new-with-error: [2, "Error", "RangeError", "TypeError", "SyntaxError", "ReferenceError"]
-
+  align-function-arguments: 2
+  align-multiline-assignment: 2
+  assert-fail-single-argument: 2
+  new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
+  no-deepEqual: 2
+  no-definegetter-definesetter: 2
 
 # Global scoped method and vars
 globals:
-  DTRACE_HTTP_CLIENT_REQUEST           : false
-  LTTNG_HTTP_CLIENT_REQUEST            : false
-  COUNTER_HTTP_CLIENT_REQUEST          : false
-  DTRACE_HTTP_CLIENT_RESPONSE          : false
-  LTTNG_HTTP_CLIENT_RESPONSE           : false
-  COUNTER_HTTP_CLIENT_RESPONSE         : false
-  DTRACE_HTTP_SERVER_REQUEST           : false
-  LTTNG_HTTP_SERVER_REQUEST            : false
-  COUNTER_HTTP_SERVER_REQUEST          : false
-  DTRACE_HTTP_SERVER_RESPONSE          : false
-  LTTNG_HTTP_SERVER_RESPONSE           : false
-  COUNTER_HTTP_SERVER_RESPONSE         : false
-  DTRACE_NET_STREAM_END                : false
-  LTTNG_NET_STREAM_END                 : false
-  COUNTER_NET_SERVER_CONNECTION_CLOSE  : false
-  DTRACE_NET_SERVER_CONNECTION         : false
-  LTTNG_NET_SERVER_CONNECTION          : false
-  COUNTER_NET_SERVER_CONNECTION        : false
+  COUNTER_HTTP_CLIENT_REQUEST: false
+  COUNTER_HTTP_CLIENT_RESPONSE: false
+  COUNTER_HTTP_SERVER_REQUEST: false
+  COUNTER_HTTP_SERVER_RESPONSE: false
+  COUNTER_NET_SERVER_CONNECTION: false
+  COUNTER_NET_SERVER_CONNECTION_CLOSE: false
+  DTRACE_HTTP_CLIENT_REQUEST: false
+  DTRACE_HTTP_CLIENT_RESPONSE: false
+  DTRACE_HTTP_SERVER_REQUEST: false
+  DTRACE_HTTP_SERVER_RESPONSE: false
+  DTRACE_NET_SERVER_CONNECTION: false
+  DTRACE_NET_STREAM_END: false
+  LTTNG_HTTP_CLIENT_REQUEST: false
+  LTTNG_HTTP_CLIENT_RESPONSE: false
+  LTTNG_HTTP_SERVER_REQUEST: false
+  LTTNG_HTTP_SERVER_RESPONSE: false
+  LTTNG_NET_SERVER_CONNECTION: false
+  LTTNG_NET_STREAM_END: false

.github/ISSUE_TEMPLATE.md

@@ -1,19 +1,13 @@
 <!--
-Thanks for wanting to report an issue you've found in Node.js. Please fill in
-the template below by replacing the html comments with an appropriate answer.
-If unsure about something, just do as best as you're able.
+Thank you for reporting an issue.
+Please fill in as much of the template below as you're able.
 
-version: usually output of `node -v`
-platform:  either `uname -a` output, or if Windows, version and 32 or 64-bit.
-subsystem:  optional -- if known please specify affected core module name.
+Version: output of `node -v`
+Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
+Subsystem: if known, please specify affected core module name
 
-It will be much easier for us to fix the issue if a test case that reproduces
-the problem is provided. Ideally this test case should not have any external
-dependencies. We understand that it is not always possible to reduce your code
-to a small test case, but we would appreciate to have as
-much data as possible.
-
-Thank you!
+If possible, please provide code that demonstrates the problem, keeping it as
+simple and free of external dependencies as you are able.
 -->
 
 * **Version**:

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,33 +1,22 @@
 <!--
-Thank you for submitting a pull request to Node.js. Before you submit, please
-review below requirements and walk through the checklist. You can 'tick'
-a box by using the letter "x": [x].
+Thank you for your pull request. Please review below requirements.
 
-Run the test suite by invoking: `make -j4 lint test` on linux or
-`vcbuild test nosign` on Windows.
+Bug fixes and new features should include tests and possibly benchmarks.
 
-If this aims to fix a regression or you’re adding a feature, make sure you also
-write a test. Finally – if possible – a benchmark that quantifies your changes.
-
-Finally, read through our contributors guide and make adjustments as necessary:
-https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
+Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
 -->
 
 ##### Checklist
+<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
 
-<!-- remove lines that do not apply to you -->
-
-- [ ] tests and code linting passes
-- [ ] a test and/or benchmark is included
+- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
+- [ ] tests and/or benchmarks are included
 - [ ] documentation is changed or added
-- [ ] the commit message follows commit guidelines
-
+- [ ] commit message follows commit guidelines
 
 ##### Affected core subsystem(s)
-
-<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->
+<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
 
 
 ##### Description of change
-
-<!-- provide a description of the change below this comment -->
+<!-- Provide a description of the change below this comment. -->

.gitignore

@@ -41,6 +41,9 @@ _UpgradeReport_Files/
 ipch/
 *.sdf
 *.opensdf
+*.VC.opendb
+.vs/
+.vscode/
 
 /config.mk
 /config.gypi

.remarkrc

@@ -0,0 +1,35 @@
+{
+  "plugins": {
+    "remark-lint": {
+      "code-block-style": false,
+      "definition-case": false,
+      "emphasis-marker": false,
+      "first-heading-level": false,
+      "heading-increment": false,
+      "list-item-content-indent": false,
+      "list-item-bullet-indent": false,
+      "list-item-indent": false,
+      "list-item-spacing": false,
+      "maximum-heading-length": false,
+      "maximum-line-length": false,
+      "no-consecutive-blank-lines": false,
+      "no-duplicate-headings": false,
+      "no-emphasis-as-heading": false,
+      "no-file-name-articles": false,
+      "no-file-name-irregular-characters": false,
+      "no-heading-punctuation": false,
+      "no-html": false,
+      "no-inline-padding": false,
+      "no-shell-dollars": false,
+      "no-shortcut-reference-link": false,
+      "no-literal-urls": false,
+      "no-missing-blank-lines": false,
+      "no-multiple-toplevel-headings": false,
+      "no-undefined-references": false,
+      "ordered-list-marker-style": false,
+      "ordered-list-marker-value": false,
+      "table-pipe-alignment": false,
+      "unordered-list-marker-style": false
+    }
+  }
+}