HC 2023 Desktop MVP #352
Merged
HC 2023 Desktop MVP #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2c87448): https://dev-nwplus-root--pr352-hackcamp2023-alvin-37jt4h2m.web.app (expires Fri, 15 Sep 2023 07:36:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ca465d4a689cc01bf206252b60f82f45b4ba90eb |
meleongg
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
MVP lgtm for Imagine Day, thank you for the hard work!
A couple things I noticed:
- stats section background doesn't fully load (unsure if it's intentional)
- top menu bar doesn't work
- apply & mentor buttons don't work yet (which is good for MVP)
- it might be more convenient to have a PR for each ticket (I realized the file diff is like 30k LOL from the images)
- loading time is kinda slow (though it might be my hotspot)
|
@meleongg noted the above comments! I'm not sure why the navbar isn't working as it is ok on local, but maybe that will change on deployment? also i think the stats background does load but the problem is everything loads really slowly LOL there are a ton of svgs. has loading time been an issue in the past? edit: think the solution is to change the big svgs into pngs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets Completed:
#344 #345 #346 #347 #348 #349 #350 #351
Desktop MVP finished with working buttons/nav
Mobile WIP, animations WIP