Fix updating scheduled broadcasts #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jul 5, 2024
| raise forms.ValidationError(_("Select when you would like the broadcast to be sent")) | ||
|
|
There was a problem hiding this comment.
the normal way to clean a form is start with cleaned_data = super().clean() but that doesn't work here.. maybe cuz it's a mixin? Anyways need to get this fix out...
rowanseymour
commented
Jul 5, 2024
| @@ -1976,7 +1976,6 @@ def setUp(self): | |||
|
|
|||
| def _form_data( | |||
| self, | |||
| org, | |||
There was a problem hiding this comment.
unrelated - just noticed this isn't used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 488 488
Lines 25041 25042 +1
=========================================
+ Hits 25041 25042 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.