Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard delete template translations that no longer exist on the channel side #5360

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Jul 5, 2024

We don't often hard delete anything but:

  1. These aren't things people are authoring in RP - they can always be re-synced from the channel if they still exist
  2. Marking things as inactive and then active again is kinda weird
  3. The thing you probably should be able to soft delete is the template.

Copy link

sentry-io bot commented Jul 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: temba/channels/models.py

Function Unhandled Issue
release Exception: Unable to update call to action: {"error":{"message":"Error validating access token: The session ... ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3235a29) to head (cd0b5c6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          488       488           
  Lines        25042     25038    -4     
=========================================
- Hits         25042     25038    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit d12d578 into main Jul 5, 2024
5 checks passed
@rowanseymour rowanseymour deleted the hard_delete_translations branch July 5, 2024 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant