Fix displaying the log missing HTTP response #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: temba/channels/models.py
Did you find this useful? React with a 👍 or 👎 |
norkans7
commented
Oct 16, 2024
| @@ -1451,16 +1451,25 @@ def test_get_display(self): | |||
| ) | |||
|
|
|||
| def test_get_display_timed_out(self): | |||
| channel = self.create_channel("TG", "Telegram", "mybot") | |||
| contact = self.create_contact("Fred Jones", urns=["telegram:74747474"]) | |||
| channel = self.create_channel( | |||
There was a problem hiding this comment.
Just updated the test so we use a channel type that has redact values to make sure they are never displayed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 543 543
Lines 25669 25669
=========================================
Hits 25669 25669 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://textit.sentry.io/issues/5995273839/