Remove unused placeholder template for workspaces with no contacts #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Oct 24, 2024
| # resolve the paginated object list so we can initialize a cache of URNs | ||
| contacts = context["object_list"] | ||
| Contact.bulk_urn_cache_initialize(contacts) | ||
|
|
||
| context["contacts"] = contacts |
There was a problem hiding this comment.
no reason to alias object_list like this
rowanseymour
force-pushed
the
remove_unused_empty_include
branch
from
f0197a0
to
a784bd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5582 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 551 551
Lines 25678 25674 -4
=========================================
- Hits 25678 25674 -4 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we must have been displaying this when a workspace has no contacts but not anymore.