Some cleanup to tickets list view #5591
Merged
+102
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Oct 29, 2024
| return "tickets:activity", "" | ||
| return "", "" | ||
|
|
||
| def derive_menu_path(self): | ||
| return f"/ticket/{self.kwargs.get('folder', 'mine')}/" | ||
| folder, status, ticket, in_page = self.tickets_path |
There was a problem hiding this comment.
this fixes not changing the menu selection if ticket_path redirects to the All folder
rowanseymour
force-pushed
the
ticket_cleanup
branch
2 times, most recently
from
0bb70b0
to
47c5731
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 551 551
Lines 25733 25728 -5
=========================================
- Hits 25733 25728 -5 ☔ View full report in Codecov by Sentry. |
rowanseymour
force-pushed
the
ticket_cleanup
branch
from
47c5731
to
152766e
Compare
rowanseymour
commented
Oct 29, 2024
| @@ -590,34 +590,35 @@ def test_list(self): | |||
| self.assertRequestDisallowed(list_url, [None]) | |||
| self.assertListFetch(list_url, [self.user, self.editor, self.admin, self.agent], context_objects=[]) | |||
|
|
|||
| # can hit this page with a uuid | |||
| # TODO: work out reverse for deep link | |||
There was a problem hiding this comment.
can't be done - django can't reverse urls with |
rowanseymour
force-pushed
the
ticket_cleanup
branch
from
152766e
to
54e7a59
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make it easier to add topic/team filtering everywhere we fetch tickets.