Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Record Replay improvements #836

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

WillNilges
Copy link
Collaborator

@WillNilges WillNilges commented Feb 12, 2025

  • Small refactoring of the replay system
  • some better logs
  • adds a simple web interface for viewing join records
  • inject join record env vars into container

@WillNilges WillNilges changed the title Wdn/replay fixes 2890128933894 Small Join Record Replay improvements Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.80%. Comparing base (8037c42) to head (8559196).

Files with missing lines Patch % Lines
src/meshapi/util/join_records.py 75.00% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   94.92%   94.80%   -0.12%     
==========================================
  Files          90       90              
  Lines        3841     3853      +12     
==========================================
+ Hits         3646     3653       +7     
- Misses        195      200       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillNilges WillNilges changed the title Small Join Record Replay improvements Join Record Replay improvements Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant