Make from field Optional to not cause Key errors #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
|
@kraju3 is this expected API behaviour...? seems odd, doesn't it? Or does it happen for drafts? |
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
|
@AaronDDM It seems like Microsoft Graph API sometimes omit this value from their response and we won't translate it on our end. Since the field is not typed to optional our SDK throws a KeyError while decoding and users won't be able to process the response via the SDK. Making it Optional will solve the KeyError so that they can at least enrich the data. |
AaronDDM
approved these changes
Sep 6, 2024
mrashed-dev
approved these changes
Sep 9, 2024
Merged
mrashed-dev
added a commit
that referenced
this pull request
Sep 24, 2024
* Add support for from field for sending messages (#386) * Add missing schedule-specific fields to Message model (#385) * Add migration grant properties (#387) * Fix from field not being optional causing deserialization errors (#382) * Fix IMAP identifiers not encoding correctly (#383) * Fix NylasOAuthError not setting the status code properly (#388, #379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://nylas.zendesk.com/agent/tickets/94722
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.