Skip to content

Commit

Permalink
Merge branch 'release/1.2.16'
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew Welch committed Jun 15, 2021
2 parents 655816e + 6f9375c commit d742dca
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 24 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# nystudio107/docker-images Change Log

## 1.2.16 - 2021.06.15
### Changed
* Removed `USER` directive in the PHP containers, since the pool runs as `www-data` already
* Fix permissions regression

## 1.2.15 - 2021.06.11
### Changed
* Cleaned up the `php-dev-craft` & `php-prod-craft` Dockerfile file permissions
Expand Down
3 changes: 0 additions & 3 deletions php-dev-craft/php-7.4-alpine/mariadb/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,3 @@ RUN mkdir -p /var/www/project/cms/storage \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data
3 changes: 0 additions & 3 deletions php-dev-craft/php-7.4-alpine/postgres/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,3 @@ RUN mkdir -p /var/www/project/cms/storage \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data
3 changes: 0 additions & 3 deletions php-dev-craft/php-8.0-alpine/mariadb/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,3 @@ RUN mkdir -p /var/www/project/cms/storage \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data
3 changes: 0 additions & 3 deletions php-dev-craft/php-8.0-alpine/postgres/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,3 @@ RUN mkdir -p /var/www/project/cms/storage \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data
5 changes: 2 additions & 3 deletions php-prod-craft/php-7.4-alpine/mariadb/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ RUN chmod a+x run_queue.sh \

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data

# Force permissions, update Craft, and start php-fpm

# Do a `composer install` without running any Composer scripts
Expand All @@ -69,6 +66,8 @@ USER www-data
# but saves far more time in not having to deal with out of sync versions
# when working with teams or multiple environments
CMD composer install --verbose --no-progress --no-scripts --optimize-autoloader --no-interaction \
&& \
chown -R www-data:www-data /var/www/project
&& \
composer craft-update \
&& \
Expand Down
5 changes: 2 additions & 3 deletions php-prod-craft/php-7.4-alpine/postgres/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ RUN chmod a+x run_queue.sh \

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data

# Force permissions, update Craft, and start php-fpm

# Do a `composer install` without running any Composer scripts
Expand All @@ -71,6 +68,8 @@ USER www-data
# but saves far more time in not having to deal with out of sync versions
# when working with teams or multiple environments
CMD composer install --verbose --no-progress --no-scripts --optimize-autoloader --no-interaction \
&& \
chown -R www-data:www-data /var/www/project
&& \
composer craft-update \
&& \
Expand Down
5 changes: 2 additions & 3 deletions php-prod-craft/php-8.0-alpine/mariadb/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ RUN chmod a+x run_queue.sh \

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data

# Force permissions, update Craft, and start php-fpm

# Do a `composer install` without running any Composer scripts
Expand All @@ -69,6 +66,8 @@ USER www-data
# but saves far more time in not having to deal with out of sync versions
# when working with teams or multiple environments
CMD composer install --verbose --no-progress --no-scripts --optimize-autoloader --no-interaction \
&& \
chown -R www-data:www-data /var/www/project
&& \
composer craft-update \
&& \
Expand Down
5 changes: 2 additions & 3 deletions php-prod-craft/php-8.0-alpine/postgres/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ RUN chmod a+x run_queue.sh \

WORKDIR /var/www/project/cms

# run container as the www-data user
USER www-data

# Force permissions, update Craft, and start php-fpm

# Do a `composer install` without running any Composer scripts
Expand All @@ -71,6 +68,8 @@ USER www-data
# but saves far more time in not having to deal with out of sync versions
# when working with teams or multiple environments
CMD composer install --verbose --no-progress --no-scripts --optimize-autoloader --no-interaction \
&& \
chown -R www-data:www-data /var/www/project
&& \
composer craft-update \
&& \
Expand Down

0 comments on commit d742dca

Please sign in to comment.