Merge branch 'develop' into brian/permisions-precondition

.github/workflows/build-action.yml

@@ -67,7 +67,8 @@ jobs:
             'DEX integration tests',
             'DEX integration test with proofs',
             'Voting integration tests',
-            'Verification Key Regression Check',
+            'Verification Key Regression Check 1',
+            'Verification Key Regression Check 2',
             'CommonJS test',
           ]
     steps:
@@ -161,9 +162,11 @@ jobs:
           shopt -s globstar
           test_files=(./dist/node/**/*.unit-test.js)
 
+          set -o pipefail
+
           for ((i=start_index; i<end_index && i<${#test_files[@]}; i++)); do
-            echo "Running test: ${test_files[$i]}"
-            node --enable-source-maps "${test_files[$i]}" | tee -a profiling.md
+              echo "Running test: ${test_files[$i]}"
+              node --enable-source-maps "${test_files[$i]}" | tee -a profiling.md
           done
         continue-on-error: false
 

CHANGELOG.md

@@ -15,14 +15,20 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
     _Security_ in case of vulnerabilities.
  -->
 
-## [Unreleased](https://github.com/o1-labs/o1js/compare/5006e4f...HEAD)
+## [Unreleased](https://github.com/o1-labs/o1js/compare/450943...HEAD)
+
+## [1.8.0](https://github.com/o1-labs/o1js/compare/5006e4f...450943) - 2024-09-18
 
 ### Added
 
 - Added `verifyEthers` method to verify Ethereum signatures using the EIP-191 message hashing standard https://github.com/o1-labs/o1js/pull/1815
   - Added `fromEthers` method for parsing and converting Ethereum public keys into `ForeignCurve` points, supporting both compressed and uncompressed formats.
   - Added `fromHex` method for converting hexadecimal strings into `ForeignCurve` points.
 
+### Fixes
+
+- Fix incorrect behavior of optional proving for zkPrograms where `myProgram.setProofsEnabled(false)` wouldn't work when called before `myProgram.compile()` https://github.com/o1-labs/o1js/pull/1827
+
 ## [1.7.0](https://github.com/o1-labs/o1js/compare/d6abf1d97...5006e4f) - 2024-09-04
 
 ### Added

README.md

@@ -1,4 +1,4 @@
-# o1js   [![npm version](https://img.shields.io/npm/v/o1js.svg?style=flat)](https://www.npmjs.com/package/o1js) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/o1-labs/o1js/blob/main/CONTRIBUTING.md)
+# o1js   [![npm version](https://img.shields.io/npm/v/o1js.svg?style=flat)](https://www.npmjs.com/package/o1js) [![npm](https://img.shields.io/npm/dm/o1js)](https://www.npmjs.com/package/o1js) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/o1-labs/o1js/blob/main/CONTRIBUTING.md)
 
 ℹ️ **o1js** is an evolution of [SnarkyJS](https://www.npmjs.com/package/snarkyjs) which saw
 49 updated versions over two years of development with 43,141 downloads.

package.json

@@ -1,7 +1,7 @@
 {
   "name": "o1js",
   "description": "TypeScript framework for zk-SNARKs and zkApps",
-  "version": "1.7.0",
+  "version": "1.8.0",
   "license": "Apache-2.0",
   "homepage": "https://github.com/o1-labs/o1js/",
   "repository": {

run-ci-tests.sh

@@ -33,12 +33,16 @@ case $TEST_TYPE in
   ./run src/examples/zkapps/dex/happy-path-with-proofs.ts --bundle
   ;;
 
-"Verification Key Regression Check")
-  echo "Running Regression checks"
+"Verification Key Regression Check 1")
+  echo "Running Regression checks part 1"
   VK_TEST=1 ./run ./tests/vk-regression/vk-regression.ts --bundle
-  VK_TEST=2 ./run ./tests/vk-regression/vk-regression.ts --bundle
   ;;
 
+"Verification Key Regression Check 2")
+  echo "Running Regression checks part 2"
+  VK_TEST=2 ./run ./tests/vk-regression/vk-regression.ts --bundle
+  ;;
+
 "CommonJS test")
   echo "Testing CommonJS version"
   node src/examples/commonjs.cjs

src/lib/proof-system/zkprogram.ts

@@ -666,9 +666,9 @@ function ZkProgram<
   async function compile({
     cache = Cache.FileSystemDefault,
     forceRecompile = false,
-    proofsEnabled = true,
+    proofsEnabled = undefined,
   } = {}) {
-    doProving = proofsEnabled;
+    doProving = proofsEnabled ?? doProving;
 
     if (doProving) {
       let methodsMeta = await analyzeMethods();