Book: repair links with mdbook-linkcheck (manually) #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
force-pushed
the
volhovm/1359-add-mdbook-linkcheck
branch
from
0fdf26b to
9c7b359
Compare
querolita
reviewed
Dec 11, 2023
book/Makefile
Outdated
| cargo install "mdbook-mermaid@$(MDBOOK_MERMAID_VERSION)" | ||
| cargo install "mdbook-toc@$(MDBOOK_TOC_VERSION)" | ||
|
|
||
| # | ||
| # use `make check` to check if your installed dependencies match what we've listed above | ||
| # Checks if your installed dependencies match what we've listed above |
There was a problem hiding this comment.
what command does this now instead? If it is not done automatically, I would keep the comment just in case someone wants to check this manually. Same with the other comments that have been changed in the Makefile.
There was a problem hiding this comment.
The same command below, make check. It's just that everything in makefile was duplicated, there was a target "mytarget" and a comment "use make mytarget to ...".
If it clarified but not confused things I can return it back?
querolita
approved these changes
Dec 11, 2023
volhovm
force-pushed
the
volhovm/1359-add-mdbook-linkcheck
branch
from
9c7b359 to
0fc9487
Compare
dannywillems
requested changes
Dec 11, 2023
This reverts commit ea5ca69.
|
@dannywillems reverted the |
| @@ -2225,9 +2226,9 @@ The prover then follows the following steps to create the proof: | |||
| 1. Evaluate the same polynomials without chunking them | |||
| (so that each polynomial should correspond to a single value this time). | |||
| 1. Compute the ft polynomial. | |||
| This is to implement [Maller's optimization](https://o1-labs.github.io/mina-book/crypto/plonk/maller_15.html). | |||
| This is to implement [Maller's optimization](https://o1-labs.github.io/mina-book/kimchi/maller_15.html). | |||
There was a problem hiding this comment.
I would use the local version.
| 1. construct the blinding part of the ft polynomial commitment | ||
| [see this section](https://o1-labs.github.io/mina-book/crypto/plonk/maller_15.html#evaluation-proof-and-blinding-factors) | ||
| [see this section](https://o1-labs.github.io/mina-book/kimchi/maller_15.html#evaluation-proof-and-blinding-factors) |
dannywillems
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1/2 of #1359 that for now does a manual pass over the book and fixes link inconsistencies.
(The future PR 2/2 will actually integrate the checker after Michael-F-Bryan/mdbook-linkcheck#81 merged)