Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added registry setting to SteadyClock that allows to disable resettin… #819

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

michalpelka
Copy link
Contributor

…g the clock when level is reloaded.

This is useful when you want to keep the clock running between level reloads, for example to keep some ROS 2 nodes happy that are running in the background, and you are reload / reset the level.

What does this PR do?

It is new feature.
It is optional, it does not change default behavior.

How was this PR tested?

Tested in external project against 2409.1
with registry adjusted:

{
    "O3DE":
    {
        "InputSystem":
        {
            "Mouse":
            {
                "CaptureMouseCursor": false
            }
        },
        "ROS2":
        {
            "SteadyClock" : true,
            "SteadyClock":
            {
                "ResetTimestampOnLevelReload": false
            },
            "Camera":
            {
                "AllowPipelineModification": false
            }
        }
    }
}

@michalpelka michalpelka requested review from a team as code owners January 22, 2025 13:04
michalpelka and others added 2 commits January 24, 2025 11:17
…g the clock when level is reloaded.

This is useful when you want to keep the clock running between level reloads,
for example to keep some ROS 2 nodes happy that are running in the background, and
you are reload / reset the level.

Signed-off-by: Michał Pełka <[email protected]>
@jhanca-robotecai jhanca-robotecai force-pushed the mp/option_to_no_reset_on_level_reload branch from b323150 to 1f3babb Compare January 24, 2025 11:34
Copy link
Contributor

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works as expected (changing via registry works); the default setting does not change the expected behavior. The feature makes sense - approve.

I rebased the code, clang-formatted, and force-pushed to ensure AR would have less issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants