Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to latest API version - added LicenceKey parameter #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fabiogermann
Copy link
Collaborator

As the current version of the API is not supported the creation of a NEW identity is not possible anymore. The following error is the result: o3ma/o3rest#2

Using the updated API and a license from the theema store (shop.threema.ch) it works again.

Also see: o3ma/o3rest#3

@cryptix
Copy link
Member

cryptix commented Jun 3, 2020

It looks like the required field was already present on CreateStage2Request, too!

LGTM apart from a minor gofmt

@fabiogermann
Copy link
Collaborator Author

@cryptix do you need me to reformat/change some things before merging?

@Mynacol
Copy link

Mynacol commented Sep 21, 2020

May I ping this merge request? I would like to see this working again 😄

@cryptix
Copy link
Member

cryptix commented Sep 22, 2020

I don't maintain this code, I just know the people who started the project.

Maybe they can add or transfer ownership of the org if people are interested to take it over. @corrupt @willnix

@fabiogermann
Copy link
Collaborator Author

fabiogermann commented Sep 26, 2020

@cryptix would be great.
@corrupt @willnix Would like to chip in on maintenance.

Comment on lines +22 to +23
POLL_CREATE_MESSAGE MsgType = 0x15 //indicates a poll message
POLL_VOTE_MESSAGE MsgType = 0x16 //indicates a poll message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why underlines are more readable but I'd personally prefer to have them all in the same pattern.

Not sure how noisy it would be to change them all. Maybe as a follow-up?

@cryptix
Copy link
Member

cryptix commented Dec 20, 2021

Would like to chip in on maintenance.

@fabiogermann I will try to make a call with corrupt and willnix before xmas or after. we'd usually would have met over c3 but not sure who of us will be there remote this year.

Personally I'd add you right away but maybe we should have quick temperature check and clear up understandings. For example I'd prefer to have at least 2 additional eyes on a PR before merging.

@fabiogermann
Copy link
Collaborator Author

@cryptix I know it has been a while. Has there been any movement on this?

@corrupt
Copy link
Contributor

corrupt commented Jan 3, 2025

@fabiogermann Do you want to take over the project? We obviously have neither the time nor the energy to maintain it and I wouldn't mind simply handing it over to someone who has a genuine interest in maintaining it.

@fabiogermann
Copy link
Collaborator Author

@corrupt yes, that would be great. Please let me know if there is anything from my side you need for this.

@corrupt
Copy link
Contributor

corrupt commented Jan 3, 2025

Not really. We were just wondering about the point of maintaining it. Threema is open-source now. I put you in as a repo maintainer for now.

@fabiogermann
Copy link
Collaborator Author

Ok, great! Regarding maintaining the project - I know a few people that have a bot based on this project and believe there is some value in keeping it (at least for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants