Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] Update jsass to bring some fixes and possibility for build under arm macos #981

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

0ffer
Copy link
Contributor

@0ffer 0ffer commented Nov 18, 2024

Changes introduced with this PR

Just small update for jsass dependency.
It has some prebuilded binaries within.
New version brings some small bug fixes and binaries for arm cpu's.
This is the only one thing that broke builds (and local work) on arm-based apple computers.

Are you the owner of the code you are sending in, or do you have permission of the owner?

yes

@0ffer
Copy link
Contributor Author

0ffer commented Jan 3, 2025

@sandrobonazzola Sandro, hello!
On local builds all looks ok.
I found some time to understand, why CI build failed.
It because used offline build, and deps taken from "ovirt-engine-build-dependencies" package, which is not include new dependency.
I can't clearly understand full road from deps repository to the CI build, but I can create PR with new dependency there (https://github.com/oVirt/ovirt-engine-build-dependencies/blob/main/.automation/build-srpm.sh#L13).
As I understand, that's how team did it before (found some description in this commit: oVirt/ovirt-engine-build-dependencies@90deacb)

I will prepare PR there in some days.

@dupondje
Copy link
Member

dupondje commented Jan 3, 2025

@0ffer :
See also oVirt/ovirt-engine-build-dependencies@eb7be7a

What happens is that if an additional dependency is added in the build-dependencies, a new rpm will be build on COPR with this dep included.
When that rpm is ready, it will be used by the CI to build ovirt-engine. As the CI does offline build and requires all deps to be installed via rpm.

Once we've passed this, the additional dependency can be removed again, as the CI of build-dependencies uses the pom from ovirt-engine to gather it dependencies.

Hope this makes it a bit more clear :)

@0ffer
Copy link
Contributor Author

0ffer commented Jan 9, 2025

I added new version in build-dependencies with this PR:
oVirt/ovirt-engine-build-dependencies#36

@dupondje dupondje force-pushed the update-jsass-dependency branch from a285306 to a528cd5 Compare January 9, 2025 09:28
@dupondje dupondje merged commit 9cd7eb8 into oVirt:master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants