CORE-5093: update list structure (#735)

* CORE-5093: update list structure * CORE-5093: fix lint issue * CORE: lint issue
oacore · Jan 29, 2025 · 6bcfdda · 6bcfdda
1 parent 6e2d53a
commit 6bcfdda
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 35 deletions.
diff --git a/src/modules/header/header.jsx b/src/modules/header/header.jsx
@@ -206,7 +206,7 @@ const Header = ({ children, className, id, ...passProps }) => {
           expanded={expandedMenu === 'communities'}
           onExpand={() => toggleMenu('communities')}
         >
-          <Group id="membership" label="Support us" tag="li">
+          <Group id="membership" label="Support us" tag="li" labelTag="a">
             <Button
               href="/membership"
               variant="contained"
@@ -238,38 +238,28 @@ const Header = ({ children, className, id, ...passProps }) => {
           expanded={expandedMenu === 'about'}
           onExpand={() => toggleMenu('about')}
         >
-          <Group id="about" label="About" tag="li">
+          <Group id="about" label="About" tag="li" labelTag="a">
             <Item href="/about">About us</Item>
             <Item href="/about#mission">Our mission</Item>
             <Item href="/about#team">Team</Item>
             <Item href="//blog.core.ac.uk">Blog</Item>
             <Item href="/faq">FAQs</Item>
             <Item href="/contact">Contact us</Item>
           </Group>
-          <Group id="community" label="Community governance" tag="li">
+          <Group
+            id="community"
+            label="Community governance"
+            tag="li"
+            labelTag="a"
+          >
             <Item href="/governance" className={styles.communitiesMenuItem}>
               Governance
             </Item>
-            <Item
-              href="/governance/advisory"
-              className={styles.communitiesMenuItem}
-            >
-              Advisory Board
-            </Item>
-            <Item
-              href="/governance/supporters"
-              className={styles.communitiesMenuItem}
-            >
-              Board of supporters
-            </Item>
-            <Item
-              href="/governance/research"
-              className={styles.communitiesMenuItem}
-            >
-              Research network
-            </Item>
+            <Item href="/governance/advisory">Advisory Board</Item>
+            <Item href="/governance/supporters">Board of supporters</Item>
+            <Item href="/governance/research">Research network</Item>
           </Group>
-          <Group id="innovations" label="Innovations" tag="li">
+          <Group id="innovations" label="Innovations" tag="li" labelTag="a">
             <Item href="/about/research-outputs">Our research</Item>
             <Item href="/innovations/labs">CORE Labs</Item>
           </Group>

diff --git a/src/modules/header/styles.css b/src/modules/header/styles.css
@@ -423,12 +423,6 @@
   }
 }
 
-.communities-menu-item a {
-  padding: 1.25rem;
-  color: var(--gray-900);
-  border-bottom: 1px dashed var(--gray-300);
-}
-
 .member-menu-item  {
   position: relative;
   display: flex;
@@ -439,18 +433,12 @@
   min-width: 172px;
   height: 68px;
   padding: .5rem;
+  margin-top: 1rem;
   background: #b75400;
   border-radius: 2px;
   box-shadow: 0 1px 2px rgba(0, 0, 0, .15);
 }
 
-.member-menu-item:first-child {
-  margin-top: 1rem;
-}
-
-.member-menu-item:nth-child(2) {
-  margin-top: .75rem;
-}
 
 .member-menu-text {
   position: absolute;