Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Section and SectionHeading #327

Closed
wants to merge 3 commits into from
Closed

Add Section and SectionHeading #327

wants to merge 3 commits into from

Conversation

viktor-yakubiv
Copy link
Member

I am not sure this is work in progress or can be merged. The implementation is copied from oacore/dashboard#443.

Styles are not copied, I think these should be separated. The rationale behind is that the current implementation allows doing something like this:

<Page id="ref">
  <Heading>REF 2021</Heading>
  <Card id="overview" tag={Section}>
    <Heading>Overview</Heading>
  </Card>
</Page>

when the styled implementation will disable such functionality. However, I am not sure about such compositing either.

This partially relates to #322 but I find that class discovery should be avoided as much as possible when aria-labelledby is very useful.

@viktor-yakubiv viktor-yakubiv self-assigned this Sep 18, 2020
@vercel
Copy link

vercel bot commented Sep 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oacore/design/66CApvdxdP6R9u515uJA4rQB8QBq
✅ Preview: https://design-git-content-oacore.vercel.app

Copy link
Member

@Joozty Joozty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind if the styles are here too but it's up to you. Feel free to merge once you solve the error in the pipeline.

@viktor-yakubiv
Copy link
Member Author

viktor-yakubiv commented Feb 3, 2022

This is actually pretty neat work, I can finish this if you would need it. @vkot91 what would you say?

@viktor-yakubiv
Copy link
Member Author

I find this stale and not needed. It was not bad chunk of work to be honest 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛️ components New components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants