Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add option for the ci to check locales #312

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Sep 3, 2024

Pull Request Template

Description

add support for a "dry-run" to "generateLocale.ts" , so that locales get checked in the CI

This helps in the case of locale updates, as the CI catches such things as in #305

This was done in a quick fashion and can certainly be improved, I didn't use a cli parser, since this just adds one simple optional option.

Any suggestions for improvements or arguments against this are welcome. ❤️

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16 Totto16 requested a review from oae September 3, 2024 16:38
add support for a "dry-run" to "generateLocale.ts" , so that locales get checked in the ci
@Totto16 Totto16 merged commit 1714020 into master Sep 16, 2024
1 check passed
@Totto16 Totto16 deleted the add_locales_check_to_ci branch September 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants