Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

targetuserspacecreator: stop skipping directory-hash #1278

Merged
merged 1 commit into from
Aug 13, 2024
Merged

targetuserspacecreator: stop skipping directory-hash #1278

merged 1 commit into from
Aug 13, 2024

Conversation

t184256
Copy link
Contributor

@t184256 t184256 commented Aug 12, 2024 •
edited by pirat89
Loading

If oamg/leapp#880 was the only FD leak,
we should be able to remove this workaround.

@github-actions GitHub Actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added the Requires Leapp PR The patch has to be merged/tested with Leapp PR label Aug 12, 2024
@pirat89 pirat89 added this to the 8.10/9.6 milestone Aug 12, 2024
pirat89
pirat89 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually and we can really drop it once the leapp stdlib is fixed.

The change has been introduced during the work on the current release so it negates original changelog.

@pirat89 pirat89 modified the milestones: 8.10/9.6, 8.10/9.5 Aug 12, 2024
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Aug 12, 2024
@pirat89
Copy link
Member

pirat89 commented Aug 12, 2024

/packit copr-build

@pirat89 pirat89 merged commit 24700ee into oamg:master Aug 13, 2024
21 checks passed
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 19, 2024
@t184256 @yuravk
targetuserspacecreator: stop skipping directory-hash (oamg#1278)
8c0b99e 
Reverting commit  60f500e

The original commit only workarounded the root cause - leaked file descriptors in the leapp stdlib when using the `run` function. Dropping the change in the actor as it is not needed anymore.

relates: oamg/leapp#880
(cherry picked from commit 24700ee)
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 20, 2024
@t184256 @yuravk
targetuserspacecreator: stop skipping directory-hash (oamg#1278)
fb5bc01 
Reverting commit  60f500e

The original commit only workarounded the root cause - leaked file descriptors in the leapp stdlib when using the `run` function. Dropping the change in the actor as it is not needed anymore.

relates: oamg/leapp#880
(cherry picked from commit 24700ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant Requires Leapp PR The patch has to be merged/tested with Leapp PR
Projects
None yet
Milestone
8.10/9.5
Development

Successfully merging this pull request may close these issues.
2 participants
@t184256 @pirat89