Skip to content

Commit

Permalink
Update comment explaining why configs is not present at the repositor…
Browse files Browse the repository at this point in the history
…y level.
  • Loading branch information
abadger committed Sep 17, 2024
1 parent abb15f8 commit ae7987e
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion leapp/repository/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,15 @@ def mapped_actor_data(data):
})
return data

# TODO: Do we need to add configs here as well?
# Note: `configs` are not present here because we are not yet making
# them globally accessible. This is to force people to copy the config
# schema to their Actors instead of importing them from other Actors.
# That copy, in turn, is a good idea so the framework can return an
# error if two Actors share the same config but they have different
# schemafor it (for instance, if Actor Foo and Bar were sharing the
# same config entry but Actor Foo updated the entry in a later version.
# We need to error so Actor Bar can either be ported to the new
# definition or use a different config entry for it's needs.)
return {
'repo_dir': self._repo_dir,
'actors': [mapped_actor_data(a.serialize()) for a in self.actors],
Expand Down

0 comments on commit ae7987e

Please sign in to comment.