Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ERROR report group #838

Closed
wants to merge 2 commits into from

Conversation

matejmatuska
Copy link
Member

Currently there is no straightforward way to identify whether a report is an ordinary report or an error report (report generated from an error).

An ERROR group is introduced in leapp.reporting.Groups.ERROR which is used to group error reports. This is utilized in the leapp output to show the number of error reports in the summary. Also error reports in leapp-report.txt are now followed by a "(error)" string similar to inhibitors.

Jira: OAMG-9532

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and leapp-repository*master* as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@@ -94,17 +94,22 @@ def fetch_upgrade_report_messages(context_id):


def is_inhibitor(message):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to keep this as it's a public API.

Linter started giving new warnings on Python 3.9, let's make it happy
again.
Currently there is no straightforward way to identify whether a report
is an ordinary report or an error report (report generated from an
error).

An `ERROR` group is introduced in `leapp.reporting.Groups.ERROR` which
is used to group error reports. This is utilized in the leapp output to
show the number of error reports in the summary. Also error reports in
`leapp-report.txt` are now followed by a "(error)" string similar to
inhibitors.

Jira: OAMG-9532
@matejmatuska matejmatuska marked this pull request as ready for review August 10, 2023 10:48
@matejmatuska
Copy link
Member Author

Example outputs

Ordinary output

normal

Output with an error

error

Output with an inhibitor

inhibitor

leapp-report.json entry
{
      "title": "Data from the /etc/fstab file is missing.",
      "timeStamp": "2023-08-10T10:57:19.568892Z",
      "hostname": "leapp-20230803161534",
      "actor": "checkfstabxfsoptions",
      "summary": "",
      "audience": "sysadmin",
      "flags": [
        "error"
      ],
      "key": "95285bcedbaf87ae0a438de13d7c6843b470717a",
      "id": "02592bc210235f83b29695cdb0b895c73d74b9994f2421fe90fd30c6c954187d",
      "tags": [],
      "severity": "high"
}
leapp-report.txt entry
Risk Factor: high (error)
Title: Data from the /etc/fstab file is missing.
Summary:
Key: 95285bcedbaf87ae0a438de13d7c6843b470717a

@matejmatuska
Copy link
Member Author

This is included in #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants