-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ERROR report group #838
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
@@ -94,17 +94,22 @@ def fetch_upgrade_report_messages(context_id): | |||
|
|||
|
|||
def is_inhibitor(message): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to keep this as it's a public API.
c475b7f
to
391b51a
Compare
Linter started giving new warnings on Python 3.9, let's make it happy again.
Currently there is no straightforward way to identify whether a report is an ordinary report or an error report (report generated from an error). An `ERROR` group is introduced in `leapp.reporting.Groups.ERROR` which is used to group error reports. This is utilized in the leapp output to show the number of error reports in the summary. Also error reports in `leapp-report.txt` are now followed by a "(error)" string similar to inhibitors. Jira: OAMG-9532
dba3c16
to
9777da7
Compare
Example outputsleapp-report.json entry
leapp-report.txt entry
|
This is included in #840 |
Currently there is no straightforward way to identify whether a report is an ordinary report or an error report (report generated from an error).
An
ERROR
group is introduced inleapp.reporting.Groups.ERROR
which is used to group error reports. This is utilized in the leapp output to show the number of error reports in the summary. Also error reports inleapp-report.txt
are now followed by a "(error)" string similar to inhibitors.Jira: OAMG-9532