Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace clean-up #199

Merged
merged 20 commits into from
Dec 4, 2023
Merged

Whitespace clean-up #199

merged 20 commits into from
Dec 4, 2023

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Oct 26, 2023

Mostly whitespace-only changes, but so widespread that merging this might lead to conflicts with many other PRs.

@HeikoTheissen HeikoTheissen marked this pull request as draft October 26, 2023 07:26
@HeikoTheissen HeikoTheissen changed the base branch from main to fix/punctuation-only October 26, 2023 07:52
@HeikoTheissen HeikoTheissen changed the title Punctuation on the wrong side of the backtick Whitespace clean-up Oct 26, 2023
Base automatically changed from fix/punctuation-only to main October 26, 2023 12:16
ralfhandl
ralfhandl previously approved these changes Nov 10, 2023
@ralfhandl ralfhandl self-requested a review November 10, 2023 15:16
Comment on lines 124 to 126
The request object and the `headers` object MUST NOT contain name/value pairs with duplicate names.
This is in conformance with [RFC7493](#rfc7493).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR depend on some other PR(s) to be merged first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it may affect most other open PRs. Do you want to merge it already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

@HeikoTheissen HeikoTheissen marked this pull request as ready for review December 4, 2023 13:54
@HeikoTheissen HeikoTheissen merged commit e002f3c into main Dec 4, 2023
1 check passed
@HeikoTheissen HeikoTheissen deleted the fix/punctuation-backtick branch December 4, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants