Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kmonad:master #17

Open
wants to merge 83 commits into
base: master
Choose a base branch
from
Open

[pull] master from kmonad:master #17

wants to merge 83 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 8, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jun 8, 2024
sujaldev and others added 28 commits June 28, 2024 13:43
fix #layer link in quick reference
Testing three-ish past versions seems plenty.
The compose sequence for grave uses <dead_grave> and not <grave>. This
key is not mapped on standard en_US and therefore irrelevant for KMonad.
The other sequences using grave are not affected, since they can also be
entered using <grave>.
Fix broken compose sequences (including #823)
Verbatim from `doc/quick-reference.md`
The init option which was added in
dcdf5b5 and deleted functionallity in
031f865

This option was used to specify a program to start when kmonad boots up.
Added some clarifications to the installation for Mac users, such as how to install stack, and how and where to find the `kmonad` executable.
Adding clarity to Mac install in installation.md
Forbid `defsrc` with duplicate keycodes.
slotThe and others added 30 commits September 3, 2024 08:41
Fixed typos in comments and docs
The following buttons have been fixed out of all effected buttons:
- [X] `around-only`
- [X] `around-when-alone`
- [ ] `around-next`
- [ ] `around-next-timeout`
- [ ] `around-next-single`
- [X] `tap-on` (does not exists but has code?!)\*
- [X] `tap-hold`
- [X] `tap-next`
- [X] `tap-hold-next`
- [ ] `before-after-next`
- [X] `tap-next-release`
- [X] `tap-hold-next-release`
- [X] `tap-next-press`
- [X] `multi-tap`
- [X] `tap-macro`
- [X] `tap-macro-release`
- [ ] `layer-next`
- [ ] `sticky-key`
- [ ] `stepped-button`

* `tap-on` is just made more readable. It wasn't broken.
Hackage needs this now. Really, it would probably be a good idea to
cabal gen-bounds and then fine-tune at some point. Not today, though.
Fixes the examples that use 'a' instead of 'Ta'.
This fixes #885.

It contained two problems:
1. `MAC_OS_X_VERSION_12_0` is not set (why? It was before, was it?).
2. The last `stack install` in the build instructions detects,
   that the flag `kmonad:dext` / `kmonad:kext` is not set and would
   recompile without it.
Since this is a frequest point of confusion in issues (see below)
I think this FAQ entry is justified even though it's just terminology
used in issues (and a small part of the tutorial).

Some examples of problems / instances where it would increase clarity:
- #886
- #877
- #846
Added names for `rfkill` and `micmute`
Fix tapping for `tap-hold-next-release`
Fixes #904.

I accidentily switched `True` and `False` in #873.
We should really add tests to check for button behaviour,
which is sadly a bit hard, if we don't want a test to require
an IO action (heavy usage of `TMVar`s) (which it does anyway, since Spec
wraps an IO monad) or want to have two distinct implementations of
`MonadK`.

Sorry, I hope this was the last bug I introduced (at least in #873).
Fix tapping for `tapMacro` and `tapMacroRelease`
Fixes #785.

The tables have been merged to reduce chance of inconsistencies.
This was possible due to the following observations:
1. `winCodeToKeyCode` always chooses the keycode with lowest value when
   duplicates exist.
2. `keyCodeToWinCode` always chooses the highest resulting possible
   keycode.

(keycode `0xFE` could change something, though it does not exist in the KMonad world.)
Added keycodes from windows and merge tables
Hold instead of tapping when `multi-tap` gets interrupted during hold
Thank you Felix Yan for packaging this.
On that note also thank you Bonnee for packaging the AUR package
previously (and currently (`kmonad-git`)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants