fix some bug #76
Open
fix some bug #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add bcf bugfix |
PatriceBlin
pushed a commit
to eshard/obfuscator-llvm
that referenced
this pull request
May 9, 2022
Upstream-Status: Pending merge request This patch will probably never be upstreamed. see: obfuscator-llvm/obfuscator#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's suppose
splitNis equal tocurr.size(), and size ofvector<int> testis alwayscurr.size() - 1(value from1 to size-1, and index from0 to size-2).Then the
i-for-loopwill produce a indexsplitN - 1, akasize-1as the last item, which will excceed the bounds ofvector<int> test.Accessing
test[i]will be undefined behavior and will return unexpected value(e.g. 268435456). This would causejandititerates within a huge range.Actually no memory issues but really costs CPU and wastes time.