coap_join_mcast_group_intf: fix interface selection on windows #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdeep1
reviewed
Oct 10, 2024
|
Thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Windows platform, a set
ifnameparameter of thecoap_join_mcast_group_intffunction is only used for debug output. Only if it isNULL, the interface which should join a multicast group is derived from the bind address. So, setting theifnameparameter on the windows platform is counterproductive.With this patch,
ifnameis always set toNULLon the windows platform and libcoap can try to derive the interface from the bind address.