CMakeLists.txt: remove vendored tinydtls build path #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not write the absolute build path into libcoapTargets.cmake. The libcoapTargets.cmake is supposed to be packaged and installed by distros. An absolute path referring to the build directory looks therefore wrong. Some build frameworks like Yocto have quality assurance check which handle these issues as a warning or as an error. Example: WARNING: libcoap-4.3.4-r0 do_package_qa: QA Issue: File /usr/lib/cmake/libcoap/libcoapTargets.cmake in package libcoap-dev contains reference to TMPDIR [buildpaths] Declaring this header files as build interface looks like the right fix. In case of a bundled tinytls library the header files should be handled like the header files from libcoap itself: Either in the build folder of libcoap or in /usr/include as declared one line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not write the absolute build path into libcoapTargets.cmake. The libcoapTargets.cmake is supposed to be packaged and installed by distros. An absolute path referring to the build directory looks therefore wrong.
Some build frameworks like Yocto have quality assurance check which handle these issues as a warning or as an error. Example:
WARNING: libcoap-4.3.4-r0 do_package_qa: QA Issue:
File /usr/lib/cmake/libcoap/libcoapTargets.cmake in package
libcoap-dev contains reference to TMPDIR [buildpaths]
Declaring this header files as build interface looks like the right fix. In case of a bundled tinytls library the header files should be handled like the header files from libcoap itself: Either in the build folder of libcoap or in /usr/include as declared one line above.