may have fixed the race #3723
Open
may have fixed the race #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunmisc many thanks for the contribution! It looks reasonable. However, it would be great to have a unit test that confirms that our current implementation has a bug. Can you please add a test? Also, check this please: https://www.yegor256.com/2024/12/15/open-source-beginner-advice.html |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these objects are used inside Atomic, we can assume that they must be thread-safe.
You can't do a check/write, because during the check, the state may change and there will already be an object there. Using synchronization primitives such as:
Acquire/Release (volatile read/write) and CAS you can avoid this, only this way and no other way (or use a locking mechanism that is high level)