fix: Fixed MB validation

oblakstudio · Jan 24, 2022 · 68f0061 · 68f0061
1 parent d911a49
commit 68f0061
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 23 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/serbian-validator-utils.php b/src/serbian-validator-utils.php
@@ -6,7 +6,7 @@
  * Checks if number is valid using check digit 11 function (mod11)
  *
  * @param  int      $number Number to check
- * @return null|number      Check digit if valid, null otherwise
+ * @return number           Check digit
  */
 function mod11($number) {
     $digits = array_reverse(str_split((string) $number));
@@ -23,7 +23,7 @@ function mod11($number) {
             return $remainder;
             break;
         case 1:
-            return null;
+            return 0;
             break;
         default:
             return 11 - $remainder;

diff --git a/src/validate-mb.php b/src/validate-mb.php
@@ -3,5 +3,10 @@
 namespace Oblak;
 
 function validateMB($mb) {
-    return strlen($mb) == 8 && substr($mb, -1) == mod11(substr($mb, 0, 7));
+    $control_number = mod11(substr($mb, 0, 7));
+    if ($control_number > 9) {
+        $control_number = 0;
+    }
+
+    return strlen($mb) == 8 && substr($mb, -1) == $control_number;
 }
diff --git a/tests/validate-mb.php b/tests/validate-mb.php
@@ -8,10 +8,11 @@
 use function Oblak\validateMB;
 
 final class MBValidationTest extends TestCase {
-    public function test_validatePIB() {
+    public function test_validateMB() {
         $this->assertTrue(validateMB(66143627));
         $this->assertFalse(validateMB(66143628));
         $this->assertFalse(validateMB(6614362));
         $this->assertFalse(validateMB(661436200));
+        $this->assertTrue(validateMB(61629190));
     }
 }