-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
note loaders #1776
Merged
note loaders #1776
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1ffe346
pass the source to the markdownpage; for example, telemetry is genera…
Fil e9e2758
a more complete build manifest
Fil e61ed62
fix types
Fil f8eef34
expand unit test to cover more cases
Fil d19ed39
Merge branch 'main' into fil/dag
Fil 4c5f743
manifest exported files and modules
Fil d2ee94f
don't manifest params
Fil 4c3e725
remove more {params}
Fil e92faf0
add _import and _file source information to the build manifest
Fil 9a366c9
add root to the build manifest
Fil f2dd876
wrap root under a config key
Fil 0407142
don't manifest _file and _import for now
Fil 1ccc6d2
test for #1767 in the manifest
Fil 8991d8a
prettier
Fil 57b1e6c
Merge branch 'main' into fil/dag
Fil 7568db3
better test for files that are their own source
Fil 0db8793
always include source; comments
mbostock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
path == null || path === file.slice(1)
testing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path === file.slice(1)
is for files that point to themselves (e.g.path=chart.js
file=/chart.js
)the
path
isnull
for pages that have nosource
this is only used in the tests for
parseMarkdown
… I can find a better way to express this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit better now; I'm still a bit unhappy with the naming (too many things we call "path")