Merge pull request #100 from observerly/refactor/focuser/getPosition

refactor: amend body type in getPosition() action in @observerly/hyper.
observerly · Apr 12, 2024 · e3bb1e2 · e3bb1e2
2 parents 2d874e1 + ccdfd89
commit e3bb1e2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/routes/filterwheel.ts b/src/routes/filterwheel.ts
@@ -31,6 +31,7 @@ export const filterwheel = (
       name: 'getPosition',
       action: <
         T = {
+          name: string
           position: number
         }
       >() => {
@@ -138,7 +139,7 @@ export const filterwheel = (
           position: number
         }
       >(body: {
-        filter: string
+        name: string
       }) => {
         const url = new URL('filterwheel/name', base)
 

diff --git a/tests/filterwheelRoutes.spec.ts b/tests/filterwheelRoutes.spec.ts
@@ -31,7 +31,7 @@ suite('@observerly/hyper Fiber API Filterwheel Client', () => {
       const position = await client.filterwheel.getPosition()
       expect(isDataResult(position)).toBe(true)
       if (!isDataResult(position)) return
-      expect(position).toStrictEqual({ position: 0 })
+      expect(position).toStrictEqual({ name: 'R', position: 0 })
     })
 
     it('should be able to determine the names of the filters in the filterwheel', async () => {
@@ -76,7 +76,7 @@ suite('@observerly/hyper Fiber API Filterwheel Client', () => {
 
     it('should be able to set the position of the filterwheel using the filter name', async () => {
       const client = setupClient(getURL('/api/v1/'))
-      const position = await client.filterwheel.setFilter({ filter: 'R' })
+      const position = await client.filterwheel.setFilter({ name: 'R' })
       expect(isDataResult(position)).toBe(true)
       if (!isDataResult(position)) return
       expect(position).toStrictEqual({ position: 1 })

diff --git a/tests/mocks/filterwheel.ts b/tests/mocks/filterwheel.ts
@@ -44,6 +44,7 @@ export const filterwheelHandlers: Handler[] = [
       }
 
       return {
+        name: 'R',
         position: 0
       }
     })
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,6 +44,7 @@ export const filterwheelHandlers: Handler[] = [ @@
           }
           return {
+            name: 'R',
             position: 0
           }
         })
@@ Expand Down @@