Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Code Link #3786

Closed
wants to merge 2 commits into from
Closed

Add plugin: Code Link #3786

wants to merge 2 commits into from

Conversation

observerw
Copy link
Contributor

@observerw observerw commented Jun 28, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/observerw/obsidian-code-link

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: Code Link Jun 28, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2][3]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Optional

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.

[1][2]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 29, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 29, 2024
@observerw observerw closed this Jun 29, 2024
@observerw observerw reopened this Jun 29, 2024
@observerw observerw closed this Jun 30, 2024
@observerw observerw reopened this Jun 30, 2024
@observerw
Copy link
Contributor Author

🤔 @ObsidianReviewBot

@observerw
Copy link
Contributor Author

@joethei Sorry to bother, but @ObsidianReviewBot doesn't seem to work.

  • I fixed all the issues noted in the automated review and updated my repository.
  • I tried close and reopen this PR.
  • I tried to wait over 6 hours.

But @ObsidianReviewBot hasn't shown up again.

@observerw observerw closed this Jul 2, 2024
@observerw observerw reopened this Jul 2, 2024
@observerw observerw closed this Jul 4, 2024
@observerw observerw deleted the patch-2 branch July 4, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants