Print browser source renderer crashes to OBS log

obsproject · Feb 27, 2025 · 52c1527 · 52c1527
1 parent 4023fad
commit 52c1527
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/browser-client.cpp b/browser-client.cpp
@@ -83,6 +83,14 @@ CefRefPtr<CefResourceRequestHandler> BrowserClient::GetResourceRequestHandler(Ce
 	return nullptr;
 }
 
+void BrowserClient::OnRenderProcessTerminated(CefRefPtr<CefBrowser>, TerminationStatus, int,
+					      const CefString &error_string)
+{
+	std::string str_text = error_string;
+	blog(LOG_ERROR, "[obs-browser: '%s'] Webpage has crashed unexpectedly! Reason: '%s'",
+	     obs_source_get_name(bs->source), str_text.c_str());
+}
+
 CefResourceRequestHandler::ReturnValue BrowserClient::OnBeforeResourceLoad(CefRefPtr<CefBrowser>, CefRefPtr<CefFrame>,
 									   CefRefPtr<CefRequest>,
 									   CefRefPtr<CefCallback>)

diff --git a/browser-client.hpp b/browser-client.hpp
@@ -98,6 +98,8 @@ class BrowserClient : public CefClient,
 	GetResourceRequestHandler(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame,
 				  CefRefPtr<CefRequest> request, bool is_navigation, bool is_download,
 				  const CefString &request_initiator, bool &disable_default_handling) override;
+	virtual void OnRenderProcessTerminated(CefRefPtr<CefBrowser> browser, TerminationStatus status, int error_code,
+					       const CefString &error_string) override;
 
 	/* CefResourceRequestHandler */
 	virtual CefResourceRequestHandler::ReturnValue OnBeforeResourceLoad(CefRefPtr<CefBrowser> browser,