-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps.qt: Remove Qt5 and update Qt6 build scripts #188
Conversation
96c640b
to
3895870
Compare
45373a6
to
5d635dd
Compare
With cmake 3.0, will we still need 32 bit deps for the remaining 32 bit components (game capture, vcam, etc.) or could they be stripped down further? |
That's implemented in #174. |
65e8d69
to
6ac25b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit.
3342c5d
to
1280333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI: Remove Qt5 and not longer needed architectures from Qt builds
not -> no
Some questions, some nits.
Local compile tests worked.
b0cf71a
to
93e5672
Compare
IIRC the standard suggests using |
76ccbc2
to
5e029c1
Compare
8578106
to
af3b971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the commits are bit heavier or more entangled with other changes than I prefer (sometimes with cosmetic changes), but it's probably more work than it's worth to split this up further or reorganize the commits. Looks good to me otherwise, and local testing showed no further issues when building with these artifacts.
Description
Removes Qt5 builds and simplifies Qt6 build matrix to only provide the following builds:
Motivation and Context
Improve CI efficiency and simplify build matrix for OBS Studio builds.
How Has This Been Tested?
Built Qt6 on Windows 11 for x64 and arm64.
Types of changes
Checklist: