-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-essential Windows x86 deps builds #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the first two commits individually work in the absence of the third commit? It looks like they should, but I wanted to confirm.
Commit message nit:
- detours -> Detours
They should, yeah. |
ef2e759
to
deaa106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. The one thing to watch out for is that it will become impossible to do full 32-bit builds in legacy CMake, so it may be helpful (though perhaps not required) to have instructions for a slim 32-bit build with just the win-capture and win-dshow components.
deaa106
to
7486d8f
Compare
Per off-thread discussion, we're going to hold off on merging this change because removing the x86 Windows deps would make doing complete Windows legacy CMake builds of obs-studio a bit burdensome. We'll remove the x86 Windows deps once we remove the legacy CMake. |
7486d8f
to
39f6075
Compare
39f6075
to
5706bcf
Compare
5706bcf
to
c80020d
Compare
Windows builds with the CMake 3.0 build system only require Detours and Vulkan libraries for the x86 modules.
c80020d
to
c18f08e
Compare
c18f08e
to
8ea352b
Compare
Can this be merged before #190? |
Yep, I kinda expected it to even. |
Let's cut down CI's workload then. |
Description
Removes x86 slices of most Windows dependencies, with the exception of Detours and Vulkan, which are both needed for capture plugins.
Motivation and Context
Deprecate all traces of standalone x86 OBS Studio versions.
How Has This Been Tested?
Tested on Windows 11 VM.
Types of changes
Checklist: