CI: Force-remove pkg-config on macOS runners and install pkgconf #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatTheMav
force-pushed
the
fix-pkg-config-macos
branch
4 times, most recently
from
87bee55 to
9759499
Compare
RytoEX
reviewed
Nov 27, 2024
Homebrew has effectively deprecated the pkg-config formula and instead aliased pkgconf to that name. Installing pkg-config via the Brewfile thus leads to Homebrew attempting to install pkgconf instead, which will fail because the (older) pkg-config formula is installed by default on macOS runners.
PatTheMav
force-pushed
the
fix-pkg-config-macos
branch
from
9759499 to
9c1930d
Compare
|
Seems fine. Is the issue with png-config expected to arise again, or is this mostly preventative at this point? |
It depends on what GitHub and Homebrew might do in the future, for now it seems to be fixed by GitHub switching explicitly to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CI failures due to pre-installed
pkg-configHomebrew formula blocking installation ofpkgconf, which is aliased topkg-configsince an update to Homebrew which was released after the new macOS runner images were created.Motivation and Context
Homebrew has effectively deprecated the pkg-config formula and instead aliased pkgconf to that name.
Installing pkg-config via the Brewfile thus leads to Homebrew attempting to install pkgconf instead, which will fail because the (older) pkg-config formula is installed by default on macOS runners.
How Has This Been Tested?
Needs to be tested on CI.
Types of changes
Checklist: